Adds Manage snapshot repositories page #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eedugon
reviewed
Feb 12, 2025
deploy-manage/tools/snapshot-and-restore/manage-snapshot-repositories.md
Outdated
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/manage-snapshot-repositories.md
Outdated
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/manage-snapshot-repositories.md
Outdated
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/manage-snapshot-repositories.md
Outdated
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/manage-snapshot-repositories.md
Outdated
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/manage-snapshot-repositories.md
Outdated
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/manage-snapshot-repositories.md
Outdated
Show resolved
Hide resolved
…itories.md Co-authored-by: Edu González de la Herrán <[email protected]>
…itories.md Co-authored-by: Edu González de la Herrán <[email protected]>
…itories.md Co-authored-by: Edu González de la Herrán <[email protected]>
…itories.md Co-authored-by: Edu González de la Herrán <[email protected]>
…itories.md Co-authored-by: Edu González de la Herrán <[email protected]>
…itories.md Co-authored-by: Edu González de la Herrán <[email protected]>
eedugon
reviewed
Feb 13, 2025
There was a problem hiding this comment.
I've added a few suggestions on the ECK side.
About ordering of subsections I'd suggest:
- Do not make the ECK a sub-section of
self-managed, keep it separated. I'm sorry if my previous comment caused confusion. ECK is considered self-managed, but ECE too. ECK and ECE are both self-managedorchestrators. And not always ECK is going to support the same as a standard self-managed / self-deployed Elasticsearch cluster.
I'd suggest to order the sub-sections like this:
- self-managed
- ech
- ece
- eck
But I'm not sure if there's a reason to start with ECH.
deploy-manage/tools/snapshot-and-restore/manage-snapshot-repositories.md
Outdated
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/manage-snapshot-repositories.md
Outdated
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/manage-snapshot-repositories.md
Outdated
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/manage-snapshot-repositories.md
Outdated
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/manage-snapshot-repositories.md
Outdated
Show resolved
Hide resolved
…itories.md Co-authored-by: Edu González de la Herrán <[email protected]>
…itories.md Co-authored-by: Edu González de la Herrán <[email protected]>
…itories.md Co-authored-by: Edu González de la Herrán <[email protected]>
…itories.md Co-authored-by: Edu González de la Herrán <[email protected]>
…itories.md Co-authored-by: Edu González de la Herrán <[email protected]>
eedugon
previously approved these changes
Feb 17, 2025
deploy-manage/tools/snapshot-and-restore/manage-snapshot-repositories.md
Outdated
Show resolved
Hide resolved
…itories.md Co-authored-by: Edu González de la Herrán <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Manage snapshot repositories overview page.