[D&M] Drafts maintenance content #421
Open
+640
−734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent into szabosteve/maintenance
szabosteve
changed the title
…ent into szabosteve/maintenance
…ent into szabosteve/maintenance
There was a problem hiding this comment.
this looks very very good!
most of my comments are nitpicks and little typo things I saw. overall:
- Please add
applies_toto all pages (the new syntax is out now) - From overview pages, link down to the pages you're referring to
- Duplicate content about adding nodes can be removed from the "start/stop es" topic
- Noted where some small glue content and clarification about what procedures apply to what deployment types would be helpful (and hopefully quick)
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
There was a problem hiding this comment.
I've provided some suggestions re: changes to the "applies_to" tags. most of my reasoning is based on extrapolating other info in the page (e.g. the install methods on start/stop es are just self-managed install methods). let me know if you disagree with any of the labeling.
sry for the second round of comments - it's looking vv great, just want to make sure we have the page scopes right 🎯
| @@ -1,6 +1,13 @@ | |||
| --- | |||
| mapped_pages: | |||
| - https://www.elastic.co/guide/en/cloud-enterprise/current/ece-manage-kibana.html | |||
| applies_to: | |||
| stack: | |||
There was a problem hiding this comment.
I think we can leave the stack label out of here because all of these pages are very deployment type specific. same for all pages
Suggested change
| stack: |
Comment on lines
+37
to
+39
| * [ECE](../deploy/cloud-enterprise/resize-deployment.md) | ||
| * [ECH](../deploy/elastic-cloud/configure.md) | ||
| * [ECK](../deploy/cloud-on-k8s/update-deployments.md) |
There was a problem hiding this comment.
Suggested change
| * [ECE](../deploy/cloud-enterprise/resize-deployment.md) | |
| * [ECH](../deploy/elastic-cloud/configure.md) | |
| * [ECK](../deploy/cloud-on-k8s/update-deployments.md) | |
| * [{{ece}}](../deploy/cloud-enterprise/resize-deployment.md) | |
| * [{{ech}}](../deploy/elastic-cloud/configure.md) | |
| * [{{eck}}](../deploy/cloud-on-k8s/update-deployments.md) |
| * [starting and stopping Elasticsearch](start-stop-services/start-stop-elasticsearch.md) | ||
| * [starting and stopping Kibana](start-stop-services/start-stop-kibana.md) | ||
| * [restarting an ECE deployment](start-stop-services/restart-an-ece-deployment.md) | ||
| * [restarting cloud-hosted deployments](start-stop-services/restart-cloud-hosted-deployment.md) |
There was a problem hiding this comment.
Suggested change
| * [restarting cloud-hosted deployments](start-stop-services/restart-cloud-hosted-deployment.md) | |
| * [restarting {{ech}} deployments](start-stop-services/restart-cloud-hosted-deployment.md) |
| applies_to: | ||
| stack: | ||
| deployment: | ||
| eck: |
There was a problem hiding this comment.
none of this applies to ECK
Suggested change
| eck: |
Comment on lines
+4
to
+10
| applies_to: | ||
| stack: | ||
| deployment: | ||
| eck: | ||
| ess: | ||
| ece: | ||
| self: |
There was a problem hiding this comment.
Suggested change
| applies_to: | |
| stack: | |
| deployment: | |
| eck: | |
| ess: | |
| ece: | |
| self: | |
| applies_to: | |
| deployment: | |
| self: |
Comment on lines
+5
to
+9
| applies_to: | ||
| deployment: | ||
| eck: | ||
| ess: | ||
| ece: |
There was a problem hiding this comment.
Suggested change
| applies_to: | |
| deployment: | |
| eck: | |
| ess: | |
| ece: | |
| applies_to: | |
| deployment: | |
| ess: |
Comment on lines
+5
to
+11
| applies_to: | ||
| stack: | ||
| deployment: | ||
| eck: | ||
| ess: | ||
| ece: | ||
| self: |
There was a problem hiding this comment.
Suggested change
| applies_to: | |
| stack: | |
| deployment: | |
| eck: | |
| ess: | |
| ece: | |
| self: | |
| applies_to: | |
| deployment: | |
| self: |
Comment on lines
+4
to
+10
| applies_to: | ||
| stack: | ||
| deployment: | ||
| eck: | ||
| ess: | ||
| ece: | ||
| self: |
There was a problem hiding this comment.
Suggested change
| applies_to: | |
| stack: | |
| deployment: | |
| eck: | |
| ess: | |
| ece: | |
| self: | |
| applies_to: | |
| deployment: | |
| self: |
Comment on lines
+15
to
+16
| * [starting and stopping Elasticsearch](start-stop-services/start-stop-elasticsearch.md) | ||
| * [starting and stopping Kibana](start-stop-services/start-stop-kibana.md) |
There was a problem hiding this comment.
Suggested change
| * [starting and stopping Elasticsearch](start-stop-services/start-stop-elasticsearch.md) | |
| * [starting and stopping Kibana](start-stop-services/start-stop-kibana.md) | |
| * [starting and stopping self-managed Elasticsearch nodes](start-stop-services/start-stop-elasticsearch.md) | |
| * [starting and stopping self-managed Kibana instances](start-stop-services/start-stop-kibana.md) |
| * [starting and stopping Kibana](start-stop-services/start-stop-kibana.md) | ||
| * [restarting an ECE deployment](start-stop-services/restart-an-ece-deployment.md) | ||
| * [restarting cloud-hosted deployments](start-stop-services/restart-cloud-hosted-deployment.md) | ||
| * [full cluster and rolling restarts](start-stop-services/full-cluster-restart-rolling-restart-procedures.md) |
There was a problem hiding this comment.
Suggested change
| * [full cluster and rolling restarts](start-stop-services/full-cluster-restart-rolling-restart-procedures.md) | |
| * [full cluster and rolling restarts for self-managed clusters](start-stop-services/full-cluster-restart-rolling-restart-procedures.md) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related to https://github.com/elastic/docs-projects/issues/353
This PR:
starting-elasticsearch.mdandstopping-elasticsearch.md) and adding an intro to the page