[Manage data] Refine Mapping section #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wajihaparvez
commented
Feb 11, 2025
| @@ -8,7 +8,7 @@ mapped_pages: | |||
| One of the most important features of {{es}} is that it tries to get out of your way and let you start exploring your data as quickly as possible. To index a document, you don’t have to first create an index, define a mapping type, and define your fields — you can just index a document and the index, type, and fields will display automatically: | |||
|
|
|||
| ```console | |||
| PUT data/_doc/1 <1> | |||
| PUT data/_doc/1 <1> | |||
There was a problem hiding this comment.
I noticed that the "1" doesn't render properly in this code block and in the bullet after. It seems to be formatted the same as other pages where it's rendering like it's supposed to. I tried to troubleshoot this but I'm at a loss. Would appreciate any ideas
There was a problem hiding this comment.
@wajihaparvez Good question! If you change "console" to "json" I think it'll work (I tried it locally and that did the trick). That is, it seems to prevent the Markdown build from interpreting the <1> as part of the code example.
There was a problem hiding this comment.
Thank you @kilfoyle, that worked!
kilfoyle
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #370
Preview here
Summary
This PR includes the following updates to the Mapping section:
Note to reviewer: Please see my comment about a wonky formatting error in one of the lift-and-shift pages. Insight is appreciated 🙏