Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring audit logging #352

Merged
merged 32 commits into from
Feb 18, 2025
Merged

Monitoring audit logging #352

merged 32 commits into from
Feb 18, 2025

Conversation

eedugon
Copy link
Contributor

@eedugon eedugon commented Feb 6, 2025 •
edited
Loading

This PR implements post-migration activities on the audit logging section of the new IA.
It covers some of the tasks from https://github.com/elastic/docs-projects/issues/350.

@eedugon eedugon marked this pull request as ready for review February 7, 2025 22:09
@eedugon
Copy link
Contributor Author

eedugon commented Feb 7, 2025

quick questions about this PR, @shainaraskas :

I have set serverless: unavailable in some pages... do you think we should add it in all of them or directly omit serverless in all these docs?

About the note that explains that audit logging is a subscription feature... should we also indicate that in Elastic Cloud and ECE they are already included? or should the link be enough for the users to realize it?

@shainaraskas
Copy link
Collaborator

shainaraskas commented Feb 13, 2025 •
edited
Loading

I have set serverless: unavailable in some pages... do you think we should add it in all of them or directly omit serverless in all these docs?

I'd just omit.

just talked to florent ... not sure. need to figure out consensus.

@eedugon
Copy link
Contributor Author

eedugon commented Feb 13, 2025

@shainaraskas,

just talked to florent ... not sure. need to figure out consensus.

Perfect! No rush anyway, we could change this at any time.

shainaraskas
shainaraskas reviewed Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really really nice!!! left some comments but this is looking great

.../ingest/ingesting-data-from-applications/ingest-data-with-python-on-elasticsearch-service.md Outdated Show resolved Hide resolved
.../ingest/ingesting-data-from-applications/ingest-data-with-nodejs-on-elasticsearch-service.md Outdated Show resolved Hide resolved
deploy-manage/monitor/logging-configuration/security-event-audit-logging.md Show resolved Hide resolved
deploy-manage/monitor/logging-configuration/security-event-audit-logging.md Outdated Show resolved Hide resolved
deploy-manage/monitor/logging-configuration/enabling-audit-logs.md Outdated Show resolved Hide resolved
deploy-manage/monitor/logging-configuration/auditing-search-queries.md Outdated Show resolved Hide resolved
deploy-manage/monitor/logging-configuration/logfile-audit-output.md Show resolved Hide resolved
deploy-manage/monitor/logging-configuration/logfile-audit-output.md Outdated Show resolved Hide resolved
deploy-manage/monitor/logging-configuration/logfile-audit-output.md Outdated Show resolved Hide resolved
deploy-manage/monitor/logging-configuration/correlating-kibana-elasticsearch-audit-logs.md Outdated Show resolved Hide resolved
@eedugon @shainaraskas
Apply suggestions from code review
df94d2c 
29 suggestions from Shaina

Co-authored-by: shainaraskas <[email protected]>
@eedugon @shainaraskas
Update deploy-manage/monitor/logging-configuration/correlating-kibana…
79e6760 
…-elasticsearch-audit-logs.md

Co-authored-by: shainaraskas <[email protected]>
@eedugon eedugon requested a review from shainaraskas February 18, 2025 11:56
shainaraskas
shainaraskas previously approved these changes Feb 18, 2025
View reviewed changes
@eedugon eedugon merged commit 8453baf into main Feb 18, 2025
4 checks passed
@eedugon eedugon deleted the monitoring_audit_logging branch February 18, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shainaraskas shainaraskas shainaraskas approved these changes

@bmorelli25 bmorelli25 Awaiting requested review from bmorelli25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eedugon @shainaraskas