-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users and roles: Overviews, cloud org, project custom roles #340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing, I love how the overviews look and how everything flows!
Just shared some minor comments, and approving anyway.
deploy-manage/users-roles/cluster-or-deployment-auth/user-authentication.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/user-authentication.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/user-authentication.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/user-roles.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Edu González de la Herrán <[email protected]>
deploy-manage/users-roles/cluster-or-deployment-auth/user-roles.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Edu González de la Herrán <[email protected]>
deploy-manage/users-roles/cluster-or-deployment-auth/user-roles.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I only saw something a bit weird, at the end of the cluster-or-deployment-auth/user-roles.md
file:
For more information, see Document-level attribute-based access control with X-Pack 6.1.
I would remove X-Pack 6.1 from there.
I wouldn't even link such an old blog, but if we keep it at least I would remove the X-Pack
mention, as it's not applicable anymore.
Anyway awesome work! Let's continue moving forward!!!
Users and roles PR
#1
. Part of https://github.com/elastic/docs-projects/issues/347Does the following (click for preview :))
cleans up raw files I used up and fixes links I broke, fixes some html stuff that was causing tests to fail
working on ECE/cluster in a separate PR to make this easier to review/merge