Add matrix to pr workflow #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
reakaleek
commented
Feb 5, 2025
•
reakaleek
commented
- @cotti fixed windows tests
- create matrix to run tests windows, linux and macos
|
Windows building now but has actual test failures I need to address. At the office today with no windows laptop though. |
Mpdreamz
reviewed
Mar 14, 2025
|
@cotti, do you mind looking at the windows tests results? Feel free to add commits to this PR. |
* DiagnosticLinkInlineParser.UpdateLinkUrl()'s Path traversal is adjusted before processing into the HTML payload * Mover received Windows-specific handling
…ly handling tests.
|
@reakaleek All passing now! |
Nice! Thank you @cotti |
Mpdreamz
reviewed
Mar 17, 2025
|
|
||
| - name: Publish AOT | ||
| run: ./build.sh publishbinaries | ||
|
|
||
| - uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
I wonder what we were using this for?
There was a problem hiding this comment.
This was there in the initial implementation of the preview build, where we would download the built binary.
Mpdreamz
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.