Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra whitespace in code block #410

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Feb 4, 2025

Context

To reproduce, go to https://elastic.github.io/docs-builder/syntax/code.html#asciidoc-syntax
and copy the code using the copy button on the top-right corner.

If you paste the code somewhere, it will show like this (first line has extra whitespaces)

			[source,sh]
--------------------------------------------------
GET _tasks
GET _tasks?nodes=nodeId1,nodeId2
GET _tasks?nodes=nodeId1,nodeId2&actions=cluster:*
--------------------------------------------------

Changes

Fix the template to not add extra white space to the code block.

How to test

Open https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/410/syntax/code.html and copy any code block and paste it somewhere.

@reakaleek reakaleek requested a review from a team February 4, 2025 11:20
@reakaleek reakaleek self-assigned this Feb 4, 2025
@reakaleek reakaleek added the fix label Feb 4, 2025
@reakaleek reakaleek marked this pull request as ready for review February 4, 2025 11:20
@reakaleek reakaleek merged commit be9cd4f into main Feb 4, 2025
5 of 6 checks passed
@reakaleek reakaleek deleted the feature/fix-extra-whitespace-code branch February 4, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants