Fix deploy preview workflow #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a conflict with the downloaded artifact in a previous step
|
🤔 But it worked just fine here |
Mpdreamz
approved these changes
Feb 4, 2025
Mpdreamz
reviewed
Feb 4, 2025
|
|
||
| - uses: elastic/docs-builder/.github/actions/aws-auth@main | ||
|
|
||
| - name: Upload to S3 | ||
| env: | ||
| PR_NUMBER: ${{ steps.pull_request.outputs.number }} | ||
| run: | | ||
| aws s3 sync . "s3://elastic-docs-v3-website-preview/${GITHUB_REPOSITORY}/pull/${PR_NUMBER}" --delete --exclude "pull_request.json" | ||
| aws s3 sync ./html "s3://elastic-docs-v3-website-preview/${GITHUB_REPOSITORY}/pull/${PR_NUMBER}" --delete |
There was a problem hiding this comment.
This works today because we publish links.json under html.
.artifacts/docs/links.json would have been better than .artifacts/docs/links.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a conflict with the downloaded artifact in a previous step
Happened in https://github.com/elastic/docs-content/actions/runs/13133333037/job/36643123193