Skip to content

Fix preview-cleanup pt3 #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

Fix preview-cleanup pt3 #334

merged 1 commit into from
Jan 23, 2025
+0 −7

Conversation

reakaleek
Copy link
Member

We can delete all deployments to clean-up the UI, but we cannot delete the environment.

We need a GH PAT for that with permissions to delete environments.

This is okay for now.

@reakaleek
Fix preview-cleanup.yml
Loading
Loading status checks…
916235a 
We can delete all deployments to clean-up the UI, but we cannot delete the environment.

We need a GH PAT for that with permissions to delete environments.

This is okay for now.
@reakaleek reakaleek added the automation packaging, ci/cd. label Jan 23, 2025
@reakaleek reakaleek requested a review from a team January 23, 2025 14:29
@reakaleek reakaleek self-assigned this Jan 23, 2025
@reakaleek reakaleek changed the title Fix preview-cleanup.yml pt3 Fix preview-cleanup pt3 Jan 23, 2025
Mpdreamz
Mpdreamz approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

We can figure this out later too, its not the end of the world that the deployment leads to a non existent url after merging.

Most folks wouldn't expect it to be there anymore.

@reakaleek reakaleek merged commit 1269895 into main Jan 23, 2025
5 of 6 checks passed
@reakaleek reakaleek deleted the reakaleek-patch-1 branch January 23, 2025 14:41
@reakaleek reakaleek added changelog:skip and removed automation packaging, ci/cd. labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz

Assignees

@reakaleek reakaleek

Labels
changelog:skip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reakaleek @Mpdreamz