Skip to content

Publish logstash docs from the 9.0 branch #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented Jun 5, 2025

Related:

Update assembler config to publish Logstash documentation from the 9.0 branch.

DO NOT MERGE yet

@karenzone karenzone requested a review from a team as a code owner June 5, 2025 21:58
@colleenmcginnis colleenmcginnis marked this pull request as draft June 5, 2025 22:12
@colleenmcginnis
Copy link
Contributor

I'm just putting this into draft to make sure it doesn't get merged before the CI updates are made in the logstash repo. 🙂

@karenzone
Copy link
Contributor Author

ci / validate-assembler (pull_request)

1 similar comment
@karenzone
Copy link
Contributor Author

ci / validate-assembler (pull_request)

@colleenmcginnis
Copy link
Contributor

My note in elastic/logstash#17701 wasn't clear. 🙈 To rerun the check, you need to click the three dots next to the check, click View details, and then click Re-run jobs. In this case I chose to just Re-run failed jobs.

image

@colleenmcginnis
Copy link
Contributor

I know the docs eng team is dealing with something in docs-builder right now so maybe we can hold this, and @reakaleek can merge when it's safe?

@karenzone
Copy link
Contributor Author

Interesting! My approach kicked off a new test cycle, but it didn't actually pass. :-D

@karenzone karenzone marked this pull request as ready for review June 11, 2025 18:07
Copy link
Member

@reakaleek reakaleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes will only have an effect after a docs-builder release and if the docs-internal-workflows workflow is updated to the latest version.

@reakaleek reakaleek enabled auto-merge (squash) June 11, 2025 18:29
@reakaleek reakaleek merged commit ec432ba into main Jun 11, 2025
15 checks passed
@reakaleek reakaleek deleted the karenzone-logstash-9.0 branch June 11, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants