-
Notifications
You must be signed in to change notification settings - Fork 572
[Bug] Makefile test-remote-cli Defined Twice #4751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eric-forte-elastic
merged 6 commits into
main
from
4750-bug-makefile-test-remote-cli-defined-twice
Jun 13, 2025
Merged
[Bug] Makefile test-remote-cli Defined Twice #4751
eric-forte-elastic
merged 6 commits into
main
from
4750-bug-makefile-test-remote-cli-defined-twice
Jun 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug - GuidelinesThese guidelines serve as a reminder set of considerations when addressing a bug in the code. Documentation and Context
Code Standards and Practices
Testing
Additional Checks
|
Mikaayenson
approved these changes
Jun 5, 2025
traut
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue link(s): #4750
Summary - What I changed
Updated the Makefile to fix the duplicate entry, and fixed a minor bug in the test script which had hard coded paths and updated the comparison logic to support relative paths, as required to remove the hard coded paths.
How To Test
Run
make test-hunting-cli
with an appropriately configured/defined.detection-rules-cfg.json
. If you are using a remote stack in this configuration, this command should produce no warnings or errors.4750_make_test_cli.txt
Checklist
bug
,enhancement
,schema
,maintenance
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist