-
Notifications
You must be signed in to change notification settings - Fork 560
fix: Fixing leftover references to sha256
method
#4690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Manual review, looks good to me! 👍
Bug - GuidelinesThese guidelines serve as a reminder set of considerations when addressing a bug in the code. Documentation and Context
Code Standards and Practices
Testing
Additional Checks
|
Appears that all have now been converted back from https://github.com/elastic/detection-rules/pull/4654/files#diff-2cdf98bba030d2fe3b81b454b0bc49f9e4d2558fa086d64e6e0b0e63780aa444L88 |
Pull Request
Issue link(s):
Summary - What I changed
Fixing the leftovers from #4621 - refactoring the usage of outdated
sha256()
methodHow To Test
Checklist
bug
,enhancement
,schema
,maintenance
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist