Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API to ms-111. #481

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Conversation

gigerdo
Copy link
Member

@gigerdo gigerdo commented Aug 29, 2024

Updating the API to ms-111 to get the latest organization API changes (to manage role assignments for organization members).

  • Also needs an update to the ECE version, as 3.7.0 is based on ms-105.
  • The make format command was also failing due to golangci-lint. Updating to the latest version fixed, but needed some small config changes.
  • The new lint version was raising a deprecation error in transport_custom.go -> The seed should not be manually set, instead the seed is already initialized to a random value by default. (Also the seed should not be set with every call as it was done before).

Description

Related Issues

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

- Also needs an update to the ECE version, as 3.7.0 is based on ms-105.
- The `make format` command was also failing due to `golangci-lint`. Updating to the latest version fixed, but needed some small config changes.
- The new lint version was raising a deprecation error in `transport_custom.go` -> The seed should not be manually set, instead the seed is already initialized to a random value by default. (Also the seed should not be set with every call as it was done before).
@gigerdo gigerdo marked this pull request as ready for review August 29, 2024 09:41
@gigerdo gigerdo requested a review from a team as a code owner August 29, 2024 09:41
Copy link
Contributor

@claudia-correia claudia-correia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gigerdo gigerdo merged commit 6d20496 into elastic:master Sep 2, 2024
2 checks passed
@gigerdo gigerdo deleted the update-api-to-ms-111 branch September 2, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants