Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline cloud-sdk-go release. #446

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Streamline cloud-sdk-go release. #446

merged 2 commits into from
Oct 18, 2023

Conversation

gigerdo
Copy link
Member

@gigerdo gigerdo commented Oct 17, 2023

  • Removes the changelog generation action
    • This step always fails since first changelogs have to be added manually
  • ECE_VERSION is not automatically updated anymore
    • We potentially release multiple times per ECE version, so it should not be increased every time.
  • Updated docs to reflect the new flow.

The release will now work like this:

  • Update ECE_BRANCH, ECE_VERSION (if necessary)
  • Generate new API and commit
  • Write changelog entries, generate changelog, commit
  • Run make tag

Description

Related Issues

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@gigerdo
Streamline cloud-sdk-go release.
ad746f7 
- Removes the changelog generation action
  - This step always fails since first changelogs have to be added manually
- ECE_VERSION is not automatically updated anymore
  - We potentially release multiple times per ECE version, so it should not be increased every time.
- Updated docs to reflect the new flow.

The release will now work like this:
- Update ECE_BRANCH, ECE_VERSION (if necessary)
- Generate new API and commit
- Write changelog entries, generate changelog, commit
- Run `make tag`
@gigerdo gigerdo requested a review from a team as a code owner October 17, 2023 15:24
dimuon
dimuon approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gigerdo gigerdo merged commit 37d988a into elastic:master Oct 18, 2023
2 checks passed
@gigerdo gigerdo deleted the downgrade-ece branch October 18, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimuon dimuon dimuon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gigerdo @dimuon