Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otel: add otelmap package for conversions between map types #42694

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

mauri870
Copy link
Member

Proposed commit message

We often have to convert to/from otel and beats mapping types in tests. Currently this logic lives inside otelconsumer and is not exported. Move it to a new otelmap package.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@mauri870 mauri870 added cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch labels Feb 13, 2025
@mauri870 mauri870 self-assigned this Feb 13, 2025
@mauri870 mauri870 requested a review from a team as a code owner February 13, 2025 15:14
@mauri870 mauri870 requested review from faec and leehinman February 13, 2025 15:14
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 13, 2025
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mauri870 mauri870 merged commit 643d153 into elastic:main Feb 14, 2025
142 checks passed
mergify bot pushed a commit that referenced this pull request Feb 14, 2025
* otel: add otelmap package for conversions between map types

* goimports

(cherry picked from commit 643d153)
mergify bot pushed a commit that referenced this pull request Feb 14, 2025
* otel: add otelmap package for conversions between map types

* goimports

(cherry picked from commit 643d153)
mauri870 added a commit that referenced this pull request Feb 14, 2025
…42710)

* otel: add otelmap package for conversions between map types

* goimports

(cherry picked from commit 643d153)

Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
pierrehilbert pushed a commit that referenced this pull request Feb 14, 2025
…42711)

* otel: add otelmap package for conversions between map types

* goimports

(cherry picked from commit 643d153)

Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants