-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otel: add otelmap package for conversions between map types #42694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
leehinman
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
mergify bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
* otel: add otelmap package for conversions between map types * goimports (cherry picked from commit 643d153)
mergify bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
* otel: add otelmap package for conversions between map types * goimports (cherry picked from commit 643d153)
This was referenced Feb 14, 2025
mauri870
added a commit
that referenced
this pull request
Feb 14, 2025
…42710) * otel: add otelmap package for conversions between map types * goimports (cherry picked from commit 643d153) Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
pierrehilbert
pushed a commit
that referenced
this pull request
Feb 14, 2025
…42711) * otel: add otelmap package for conversions between map types * goimports (cherry picked from commit 643d153) Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-8.x
Automated backport to the 8.x branch with mergify
backport-9.0
Automated backport to the 9.0 branch
cleanup
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
We often have to convert to/from otel and beats mapping types in tests. Currently this logic lives inside otelconsumer and is not exported. Move it to a new otelmap package.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.