Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.18] feat(fips): bump sarama to drop kerberos lib in fips mode (backport #16032) #16040

Open
wants to merge 1 commit into
base: 8.18
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 6, 2025

Motivation/summary

bump sarama to latest commit and verify kerberos lib is not linked in the binary

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

build binary in fips mode
validate kerberos lib in not linked in the final binary

Related issues

Closes #15860


This is an automatic backport of pull request #16032 done by [Mergify](https://mergify.com).

* feat(fips): bump sarama to drop kerberos lib in fips mode

bump sarama to latest commit and verify kerberos lib is not linked in the
binary

* lint: regenerate notice file

(cherry picked from commit ac609da)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
@mergify mergify bot requested a review from a team as a code owner March 6, 2025 15:02
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Mar 6, 2025
Copy link
Contributor Author

mergify bot commented Mar 6, 2025

Cherry-pick of ac609da has failed:

On branch mergify/bp/8.18/pr-16032
Your branch is up to date with 'origin/8.18'.

You are currently cherry-picking commit ac609dae.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   NOTICE.txt
	both modified:   go.mod
	both modified:   go.sum

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Mar 10, 2025

This pull request has not been merged yet. Could you please review and merge it @kruskall? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant