Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf: add standalone apm server profiles with NVMe SSDs and io2 EBS #15624

Merged
merged 10 commits into from
Feb 10, 2025

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Feb 7, 2025

Motivation/summary

Improve benchmarking tf setup to facilitate benchmarking on standalone apm server setup with faster disks (e.g. local NVMe SSD)

  • Add NVMe c6id ec2 instance profiles
  • Use NVMe disk for data directory for instance types with d., e.g. c6id.2xlarge
  • Configurable disk IOPS which is a required field for io2 volume type
  • Bigger worker instance for 32GB profile to avoid OOM

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Run github benchmark workflow with standalone and profile

Related issues

Part of #11346

@carsonip carsonip requested a review from a team as a code owner February 7, 2025 23:10
Copy link
Contributor

mergify bot commented Feb 7, 2025

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

Copy link
Contributor

mergify bot commented Feb 7, 2025

⚠️ The sha of the head commit of this PR conflicts with #15599. Mergify cannot evaluate rules on this PR. ⚠️

@carsonip carsonip marked this pull request as draft February 8, 2025 00:13
@carsonip carsonip changed the title tf: configurable disk iops, GH configurable standalone apm instance size, use NVMe disk if available tf: add NVMe standalone apm server profiles Feb 10, 2025
@carsonip carsonip marked this pull request as ready for review February 10, 2025 15:09
@carsonip carsonip added backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch labels Feb 10, 2025
@carsonip carsonip changed the title tf: add NVMe standalone apm server profiles tf: add standalone apm server profiles with NVMe SSDs Feb 10, 2025
@carsonip carsonip changed the title tf: add standalone apm server profiles with NVMe SSDs tf: add standalone apm server profiles with NVMe SSDs and io2 EBS Feb 10, 2025
@carsonip carsonip enabled auto-merge (squash) February 10, 2025 19:09
@carsonip carsonip merged commit 3afe1fd into main Feb 10, 2025
13 checks passed
@carsonip carsonip deleted the tf-nvme-ssd branch February 10, 2025 19:13
mergify bot pushed a commit that referenced this pull request Feb 10, 2025
…5624)

Improve benchmarking tf setup to facilitate benchmarking on standalone apm server setup with faster disks (e.g. local NVMe SSD)
- Add NVMe c6id ec2 instance profiles
- Use NVMe disk for data directory for instance types with d., e.g. c6id.2xlarge
- Configurable disk IOPS which is a required field for io2 volume type
- Bigger worker instance for 32GB profile to avoid OOM

(cherry picked from commit 3afe1fd)
mergify bot pushed a commit that referenced this pull request Feb 10, 2025
…5624)

Improve benchmarking tf setup to facilitate benchmarking on standalone apm server setup with faster disks (e.g. local NVMe SSD)
- Add NVMe c6id ec2 instance profiles
- Use NVMe disk for data directory for instance types with d., e.g. c6id.2xlarge
- Configurable disk IOPS which is a required field for io2 volume type
- Bigger worker instance for 32GB profile to avoid OOM

(cherry picked from commit 3afe1fd)
mergify bot pushed a commit that referenced this pull request Feb 10, 2025
…5624)

Improve benchmarking tf setup to facilitate benchmarking on standalone apm server setup with faster disks (e.g. local NVMe SSD)
- Add NVMe c6id ec2 instance profiles
- Use NVMe disk for data directory for instance types with d., e.g. c6id.2xlarge
- Configurable disk IOPS which is a required field for io2 volume type
- Bigger worker instance for 32GB profile to avoid OOM

(cherry picked from commit 3afe1fd)
mergify bot added a commit that referenced this pull request Feb 10, 2025
…5624) (#15656)

Improve benchmarking tf setup to facilitate benchmarking on standalone apm server setup with faster disks (e.g. local NVMe SSD)
- Add NVMe c6id ec2 instance profiles
- Use NVMe disk for data directory for instance types with d., e.g. c6id.2xlarge
- Configurable disk IOPS which is a required field for io2 volume type
- Bigger worker instance for 32GB profile to avoid OOM

(cherry picked from commit 3afe1fd)

Co-authored-by: Carson Ip <[email protected]>
mergify bot added a commit that referenced this pull request Feb 10, 2025
…5624) (#15657)

Improve benchmarking tf setup to facilitate benchmarking on standalone apm server setup with faster disks (e.g. local NVMe SSD)
- Add NVMe c6id ec2 instance profiles
- Use NVMe disk for data directory for instance types with d., e.g. c6id.2xlarge
- Configurable disk IOPS which is a required field for io2 volume type
- Bigger worker instance for 32GB profile to avoid OOM

(cherry picked from commit 3afe1fd)

Co-authored-by: Carson Ip <[email protected]>
mergify bot added a commit that referenced this pull request Feb 10, 2025
…5624) (#15655)

Improve benchmarking tf setup to facilitate benchmarking on standalone apm server setup with faster disks (e.g. local NVMe SSD)
- Add NVMe c6id ec2 instance profiles
- Use NVMe disk for data directory for instance types with d., e.g. c6id.2xlarge
- Configurable disk IOPS which is a required field for io2 volume type
- Bigger worker instance for 32GB profile to avoid OOM

(cherry picked from commit 3afe1fd)

Co-authored-by: Carson Ip <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants