Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] terraform: support TBS in standalone_apm_server (backport #15337) #15341

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 23, 2025

Motivation/summary

Support TBS in testing/infra/terraform/modules/standalone_apm_server

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Run testing/benchmark with tfvars

apm_server_tail_sampling = true
apm_server_tail_sampling_storage_limit = "30GB"
run_standalone = true
standalone_apm_server_instance_size = "c6id.2xlarge"
worker_instance_type = "c6i.4xlarge"
standalone_apm_server_volume_type = "gp3"
standalone_apm_server_volume_size = 40

Output should contain a non-zero tbs_lsm_size e.g.

BenchmarkAgentAll-512        871         163274501 ns/op                 0 error_responses/sec        2205 errors/sec        19059 events/sec          995.0 gc_cycles        1049 max_goroutines        937528464 max_heap_alloc          4870724 max_heap_objects     1078747136 max_rss              22.21 mean_available_indexers            16854 metrics/sec           0 spans/sec      30967789 tbs_lsm_size  148710064 tbs_vlog_size                 0 txs/sec      436651105 B/op   4260866 allocs/op

Related issues

Follow up to #14985

Meta issue #14931


This is an automatic backport of pull request #15337 done by [Mergify](https://mergify.com).

Support TBS in testing/infra/terraform/modules/standalone_apm_server

(cherry picked from commit f6af1e9)
@mergify mergify bot added the backport label Jan 23, 2025
@mergify mergify bot requested a review from a team as a code owner January 23, 2025 09:39
@mergify mergify bot merged commit 7b0dbdc into 8.x Jan 23, 2025
20 checks passed
@mergify mergify bot deleted the mergify/bp/8.x/pr-15337 branch January 23, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant