Fix sanic cookies headers serialization #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are getting a Cookie instance from Sanic that by default get translate to a dict that is not a proper type for an header. Instead convert it to its string represantation.
xrmx
changed the title
xrmx
force-pushed
the
fix-sanic-cookies-serialization
branch
from
8a56fd8 to
70d3145
Compare
Because it fails with:
/lib/python3.8/site-packages/sanic/helpers.py:21: in <module>
STATUS_CODES: dict[int, bytes] = {
E TypeError: 'type' object is not subscriptabl
estolfo
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This is a follow up of #2190 that fixes the full matrix.
We are getting a Cookie instance from Sanic that by default get translated to a dict that is not a proper type for an header. Instead convert it to its string representation.
Also use a syntax for setting cookies that work on older versions.