Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add field_name to ConfigurationError messages on init #2133

Merged
merged 4 commits into from
Dec 24, 2024
Merged

Add field_name to ConfigurationError messages on init #2133

merged 4 commits into from
Dec 24, 2024

Conversation

radupotop
Copy link
Contributor

What does this pull request do?

Make ConfigurationError messages more descriptive on init. This is especially useful where ENV variables are not set.

Turns this error message:

ERROR      {/usr/local/lib/python3.10/site-packages/elasticapm/base.py}  is not a float

into this:

ERROR      {/usr/local/lib/python3.10/site-packages/elasticapm/base.py} TRANSACTION_SAMPLE_RATE= is not a float

@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Oct 3, 2024 •
edited
Loading

💚 CLA has been signed

@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Oct 3, 2024
@radupotop
Copy link
Contributor Author

Signed CLA

@xrmx
Copy link
Member

xrmx commented Oct 10, 2024 •
edited
Loading

@radupotop thanks for the PR, please run black on it and I'll review it

@xrmx xrmx mentioned this pull request Dec 24, 2024
Merged
xrmx
xrmx approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks like a nice improvement

@xrmx xrmx enabled auto-merge (squash) December 24, 2024 13:59
@xrmx
Copy link
Member

xrmx commented Dec 24, 2024

run docs-build

@xrmx xrmx merged commit 778797b into elastic:main Dec 24, 2024
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrmx xrmx xrmx approved these changes

Assignees
No one assigned
Labels
agent-python community Issues opened by the community triage Issues awaiting triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radupotop @xrmx