Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sites that open links in about:blank popups #36

Open
eladnava opened this issue Feb 21, 2017 · 2 comments
Open

Support for sites that open links in about:blank popups #36

eladnava opened this issue Feb 21, 2017 · 2 comments

Comments

@eladnava
Copy link
Owner

eladnava commented Feb 21, 2017

Some sites open links in a new popup to about:blank and then issues a JavaScript / <meta> redirect, as described here:
http://stackoverflow.com/a/18452171/1123355

These links currently simply open a blank window without loading anything.

If such a website is wrapped in a webview, everything becomes more difficult: e.targetUrl in the 'newwindow' handler above will contain "about:blank", so without modification the code will open a blank window/tab. To intercept the subsequent redirect from the guest, the app will also have to use the chrome.webRequest API (the documentation appears to be for extensions only, but the API is already available for packaged apps in the stable channel, too)

The code for detecting this is pretty ugly and would require us to start requesting the webRequest permission to install the extension, something that might seem fishy to some users. The ideal solution would not require eavesdropping on users' web requests.

In any case, most pop-up links will work as expected now.

@eladnava
Copy link
Owner Author

I believe #25 (hosted app migration) will resolve this but it is pending Chrome Dev to implement.

@eladnava
Copy link
Owner Author

Possible workaround:
#25 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant