Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup windows open outside of app #18

Closed
markmcintyre opened this issue May 31, 2016 · 7 comments
Closed

Popup windows open outside of app #18

markmcintyre opened this issue May 31, 2016 · 7 comments

Comments

@markmcintyre
Copy link

markmcintyre commented May 31, 2016

It would be nice if pop-up windows could open up within the app instead of a separate browser instance.

Links with target="_blank" currently open in another instance, which makes perfect sense to me, but any window that opens in a popup (via window.open, for example) is usually part of the host application and should open up in the applicationized instance instead of the browser.

eladnava added a commit that referenced this issue May 31, 2016
@eladnava
Copy link
Owner

eladnava commented May 31, 2016

Hey @markmcintyre,

Thanks for reporting this bug! I have just issued a fix and deployed it to https://applicationize.me/now. Let me know how it works for you! =)

@markmcintyre
Copy link
Author

Thanks for the quick work!

One issue: New windows generated by the Outlook Web App are all blank. I'm not sure what method Outlook is using to populate the new windows, so I'm not sure how to recommend a fix. It might be something unusual on the web application's end.

@eladnava
Copy link
Owner

eladnava commented Jun 4, 2016

@markmcintyre this must be because Outlook Web App opens a new popup to about:blank and then issues a JavaScript / <meta> redirect, as described here:
http://stackoverflow.com/a/18452171/1123355

If such a website is wrapped in a webview, everything becomes more difficult: e.targetUrl in the 'newwindow' handler above will contain "about:blank", so without modification the code will open a blank window/tab. To intercept the subsequent redirect from the guest, the app will also have to use the chrome.webRequest API (the documentation appears to be for extensions only, but the API is already available for packaged apps in the stable channel, too)

The code for detecting this is pretty ugly and would require us to start requesting the webRequest permission to install the extension, something that might seem fishy to some users. I'm going to close this for now unless you can think of a solution to this problem that doesn't require a new shady permission or hacky code. =)

In any case, most pop-ups will work as expected now.

@eladnava
Copy link
Owner

#31 now provides an option to open links outside of the app.

@eladnava
Copy link
Owner

about:blank issue relocated to #36 since it is not related to the original issue posted here.

@bradhenderson07
Copy link

I love the idea of the app but it doesn't work for logging in to a lot of apps. For example, I can't even get into feedly because of the pop-up that comes up when you try to log in. I was finally able to get into Asana by creating a Username and password but I was having the same problem as feedly when I tried signing in with Google.

@eladnava
Copy link
Owner

@bradhenderson07 Consider a possible workaround here:
#25 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants