New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support `aspectwithbg` style #137

Open

horiuchi wants to merge 2 commits into elad:master from horiuchi:support-aspectwithbg

Contributor

horiuchi commented Aug 9, 2016

No description provided.

horiuchi added 2 commits

August 9, 2016 14:40


          support aspectwithbg style

0ef4c9a


          add test case

7dfa6c5

Contributor

dustingraves commented Aug 10, 2016

👍
Works on my machine.

Contributor

dustingraves commented Aug 13, 2016

I did notice that it does not work with GIFs (tested with http://cdn.osxdaily.com/wp-content/uploads/2013/07/dancing-banana.gif) because the native code defaults the background to black on gif -> jpg conversion. It also has a problem with some transparent PNGs. i.e: this works http://img.rarediseaseday.org.s3.amazonaws.com/download/rdd-logo-transparent.png but not this http://img07.deviantart.net/da05/i/2013/033/9/2/png_rock_and_tree_by_moonglowlilly-d5tkhw3.png

Collaborator

rchipka commented Sep 1, 2016

Is this fully implemented by #140?

Contributor Author

horiuchi commented Sep 2, 2016

@rchipka No, I need new style that scales the image and fill the rest by background color. It's same as aspectfill, but not cropped image size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet