Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET8 support #77

Merged
merged 5 commits into from
Apr 27, 2024
Merged

NET8 support #77

merged 5 commits into from
Apr 27, 2024

Conversation

iRubens
Copy link
Contributor

@iRubens iRubens commented Apr 12, 2024

Hi @ektrah ,
as you're probably aware last year NET8 was released.

Being a LTS release with a lot of performance improvements it would be nice to support it directly.

I've tried to add the support for it, tests are ok on NET 6, 7 and 8.

@ektrah
Copy link
Owner

ektrah commented Apr 13, 2024

Thanks for your contribution!

As you probably know, there is no problem using an assembly compiled for net6.0 in a project that targets net8.0. You only need assemblies compiled for multiple frameworks if there are actually differences between those assemblies, e.g., if you use #if NET8_0_OR_GREATER or similar.

NSec doesn't have any #ifs. So, unless there are significant compiler changes that generate different assembles for net6.0 and net8.0, I think compiling for both net6.0 and net8.0 just doubles the size of the NuGet package. I'd prefer not to do that, tbh.

Thanks for updating the tests, though. That's overdue. May I ask you to also update the GH Actions workflow while you're at it?

@iRubens
Copy link
Contributor Author

iRubens commented Apr 15, 2024

Haha TIL about "forward" support for >NET6 projects. I reverted the projects to single NET6 target.
I also tried to update the actions to reflect the NET8 support (supposing they work like DevOps' pipelines).
I'm hoping it'll work nicely.

@ektrah ektrah merged commit 8a86a7b into ektrah:master Apr 27, 2024
15 checks passed
@ektrah
Copy link
Owner

ektrah commented Apr 27, 2024

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants