Skip to content

Commit

Permalink
Disable test coverage
Browse files Browse the repository at this point in the history
It wasn't used and it prevents tests from being cached.

See golang/go#23565 for more details.
  • Loading branch information
2opremio committed Jun 28, 2019
1 parent 05d9871 commit 7e59e72
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
7 changes: 3 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ git_commit := $(shell git describe --dirty --always)
version_pkg := github.com/weaveworks/eksctl/pkg/version

# The dependencies version should be bumped every time the build dependencies are updated
EKSCTL_DEPENDENCIES_IMAGE ?= weaveworks/eksctl-build:deps-0.3
EKSCTL_DEPENDENCIES_IMAGE ?= weaveworks/eksctl-build:deps-0.4
EKSCTL_BUILDER_IMAGE ?= weaveworks/eksctl-builder:latest
EKSCTL_IMAGE ?= weaveworks/eksctl:latest

Expand Down Expand Up @@ -54,16 +54,15 @@ test: ## Run unit test (and re-generate code under test)
$(MAKE) lint
$(MAKE) generate-aws-mocks-test generate-bindata-assets-test generate-kubernetes-types-test
$(MAKE) unit-test
test -z $(COVERALLS_TOKEN) || time "$(GOBIN)/goveralls" -coverprofile=coverage.out -service=circle-ci
$(MAKE) build-integration-test

.PHONY: unit-test
unit-test: ## Run unit test only
CGO_ENABLED=0 time go test -covermode=count -coverprofile=coverage.out ./pkg/... ./cmd/... $(UNIT_TEST_ARGS)
CGO_ENABLED=0 time go test ./pkg/... ./cmd/... $(UNIT_TEST_ARGS)

.PHONY: unit-test-race
unit-test-race: ## Run unit test with race detection
CGO_ENABLED=1 time go test -race -covermode=atomic -coverprofile=coverage.out ./pkg/... ./cmd/... $(UNIT_TEST_ARGS)
CGO_ENABLED=1 time go test -race ./pkg/... ./cmd/... $(UNIT_TEST_ARGS)

.PHONY: build-integration-test
build-integration-test: ## Build integration test binary
Expand Down
1 change: 0 additions & 1 deletion install-build-deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ fi
go install github.com/jteeuwen/go-bindata/go-bindata
go install github.com/weaveworks/github-release
go install golang.org/x/tools/cmd/stringer
go install github.com/mattn/goveralls
go install github.com/vektra/mockery/cmd/mockery


Expand Down
1 change: 0 additions & 1 deletion tools.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import (
_ "github.com/goreleaser/goreleaser"
_ "github.com/jteeuwen/go-bindata/go-bindata"
_ "github.com/kubernetes-sigs/aws-iam-authenticator/cmd/aws-iam-authenticator"
_ "github.com/mattn/goveralls"
_ "github.com/vektra/mockery/cmd/mockery"
_ "github.com/weaveworks/github-release"
_ "golang.org/x/tools/cmd/stringer"
Expand Down

0 comments on commit 7e59e72

Please sign in to comment.