Fix Notion GUID detection

build-scripts/prepare-static/index.js

@@ -17,7 +17,7 @@ async function init() {
     await clearCachedImages(IMAGES_URLS_PATH);
 
     console.log('Get list from Notion')
-    const items = await getPlacemarksData();
+    const items = (await getPlacemarksData()).slice(0,5);
     const imageUrls = getImagesUrls(items);
 
     console.log(`Download ${imageUrls.length} images`);
@@ -48,24 +48,22 @@ async function clearCachedImages(path) {
 async function downloadImages(urls) {
     const downloadImage = (url) =>
         new Promise((resolve, reject) => {
-            const [filename] = new URL(url).pathname.split('/').slice(-1);
-            const ext = filename.split('.').slice(-1)[0];
-            const notionGUID = getNotionGUID(url);
-            const outputFilename = notionGUID ? `${notionGUID}.${ext}` : filename;
-
-            const file = fs.createWriteStream(IMAGES_URLS_PATH + outputFilename);
+            const ext = new URL(url).pathname.split('.').at(-1);
+            const guid = getNotionGUID(url);
+            const filename = `${guid}.${ext}`;
+            const file = fs.createWriteStream(IMAGES_URLS_PATH + filename);
 
             https.get(url, (response) => {
                 response.pipe(file);
             });
 
             file.on('finish', () => {
                 file.close();
-                resolve({ id: notionGUID, path: outputFilename });
+                resolve({ id: guid, path: filename });
             });
 
             file.on('error', (e) => {
-                console.error(`Not loaded: ${outputFilename}`, e);
+                console.error(`Not loaded: ${filename}`, e);
                 reject();
             });
         });
@@ -100,10 +98,8 @@ function saveMetadata(cachPath, items, images) {
         ...item,
         images: item.images
             .map((url) => {
-                const notionGUID = url.includes('notion-static.com')
-                    ? url.match(/secure.notion-static.com\/(.*)\//)[1]
-                    : '';
-                const image = imagesById[notionGUID];
+                const guid = getNotionGUID(url);
+                const image = imagesById[guid];
 
                 if (image) {
                     return {

build-scripts/prepare-static/utils.js

@@ -5,5 +5,6 @@ export function log(message = '', getMessage = () => '') {
     };
 }
 
-export const getNotionGUID = (url) =>
-    url.includes('notion-static.com') ? url.match(/secure.notion-static.com\/(.*)\//)[1] : '';
+export function getNotionGUID(notionFileUrl) {
+    return new URL(notionFileUrl).pathname.split('/').at(-2);
+}