trash #177
Open
trash #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch by Tatu Saloranta; reviewed by Ekaterina Dimitrova, Brandon Williams, Michael Semb Wever for CASSANDRA-16851
ekaterinadimitrova2
force-pushed
the
trunk
branch
from
bb0e93a to
537544e
Compare
ekaterinadimitrova2
force-pushed
the
trunk
branch
from
537544e to
df6ecaa
Compare
ekaterinadimitrova2
pushed a commit
that referenced
this pull request
May 30, 2024
…usage (#177) * STAR-745: Add BloomFilter global memory limit Added a memory limiter which is a global instance (static field in BloomFilter) which monitors the total memory used by all created (and deserialized) Bloom filters. When the limit is reached we return a dummy always-true filter with a log error message. * STAR-745: Recreate Bloom filter on startup In certain situations BF will be recreated on startup (for example, if FP chance changed more than the defined tolerance). Reviewed by: Daniel Jatnieks <[email protected]> Co-authored-by: Stefania Alborghetti <[email protected]> (cherry picked from commit c1a2595) (cherry picked from commit a75b01a) (cherry picked from commit de52f5c) (cherry picked from commit 1a0ae2c) (cherry picked from commit 191305d)
ekaterinadimitrova2
pushed a commit
that referenced
this pull request
May 30, 2024
…usage (#177) * STAR-745: Add BloomFilter global memory limit Added a memory limiter which is a global instance (static field in BloomFilter) which monitors the total memory used by all created (and deserialized) Bloom filters. When the limit is reached we return a dummy always-true filter with a log error message. * STAR-745: Recreate Bloom filter on startup In certain situations BF will be recreated on startup (for example, if FP chance changed more than the defined tolerance). Reviewed by: Daniel Jatnieks <[email protected]> Co-authored-by: Stefania Alborghetti <[email protected]> (cherry picked from commit c1a2595) (cherry picked from commit a75b01a) (cherry picked from commit de52f5c) (cherry picked from commit 1a0ae2c) (cherry picked from commit 191305d) (cherry picked from commit 140d446) (cherry picked from commit ed14633)
ekaterinadimitrova2
pushed a commit
that referenced
this pull request
Jun 3, 2024
…usage (#177) * STAR-745: Add BloomFilter global memory limit Added a memory limiter which is a global instance (static field in BloomFilter) which monitors the total memory used by all created (and deserialized) Bloom filters. When the limit is reached we return a dummy always-true filter with a log error message. * STAR-745: Recreate Bloom filter on startup In certain situations BF will be recreated on startup (for example, if FP chance changed more than the defined tolerance). Reviewed by: Daniel Jatnieks <[email protected]> Co-authored-by: Stefania Alborghetti <[email protected]> (cherry picked from commit c1a2595) (cherry picked from commit a75b01a) (cherry picked from commit de52f5c) (cherry picked from commit 1a0ae2c) (cherry picked from commit 191305d) (cherry picked from commit 140d446) (cherry picked from commit ed14633) (cherry picked from commit 82e6816) STAR-745 Fix compile issues and adapt memory limiter use in BloomFilterSerializer. (cherry picked from commit 69d1545)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.