Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for redis_family #250

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

PandelisZ
Copy link

@PandelisZ PandelisZ commented Jul 10, 2023

I'm using upstash redis on fly which networks via IPV6.

Ioredis does not like this, so you have to pass a setting

2023-07-10T20:59:39Z app[32874363c77138] fra [info]{"@timestamp":"2023-07-10T20:59:39","context":"BullQueuesService","label":"bull-monitor","log":{"level":"info"},"message":"[publish] Error: getaddrinfo ENOTFOUND [REDACTED].upstash.io","timestampDiff":"+11ms"}

@ejhayes ejhayes added the minor Increment the minor version when merged label Jul 18, 2023
@ejhayes ejhayes changed the title feat: redi_family option so it can work with upstash feat: redis_family option so it can work with upstash Jul 18, 2023
@ejhayes ejhayes changed the title feat: redis_family option so it can work with upstash feat: add support for redis_family Jul 18, 2023
@ejhayes
Copy link
Owner

ejhayes commented Jul 18, 2023

Thanks for opening this PR @PandelisZ. Looks like the tests are hanging. Change looks good but I'll need to dig into this not working before I can bring this change in...hopefully should be resolved by mid week.

@PandelisZ
Copy link
Author

PandelisZ commented Jul 19, 2023

Let me know if theres anything I can do to test it :)

Is there CI ? or is it like just a npm run test ?

We're running this on our production bull now and are very happy with it and its working smooooothly :) so thanks for your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants