fix: tests after strict property removal

Signed-off-by: Vincent Biret <[email protected]>
eiriktsarpalis · Dec 9, 2024 · 3d7e68d · 3d7e68d
1 parent 4ca0d1d
commit 3d7e68d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 31 deletions.
diff --git a/dotnet/src/Connectors/Connectors.OpenAI.UnitTests/Core/OpenAIFunctionTests.cs b/dotnet/src/Connectors/Connectors.OpenAI.UnitTests/Core/OpenAIFunctionTests.cs
@@ -45,19 +45,6 @@ public void ItInitializesOpenAIFunctionReturnParameterCorrectly(string? descript
         Assert.Same(schema, functionParameter.Schema);
     }
 
-    [InlineData(null, false)]
-    [InlineData(true, false)]
-    [InlineData(false, false)]
-    [InlineData(null, true)]
-    [InlineData(true, true)]
-    [InlineData(false, true)]
-    [Theory]
-    public void ItSetsTheStrictModeAccordingToAllowance(bool? allowed, bool strict)
-    {
-        OpenAIFunction sut = new KernelFunctionMetadata("foo") { Strict = strict }.ToOpenAIFunction(allowed);
-        Assert.Equal((allowed ?? true) && strict, sut.Strict);
-    }
-
     [Fact]
     public void ItCanConvertToFunctionDefinitionWithNoPluginName()
     {
@@ -78,21 +65,19 @@ public void ItCanConvertToFunctionDefinitionWithNoPluginName()
     public void ItCanConvertToFunctionDefinitionWithNullParameters(bool strict)
     {
         // Arrange
-        OpenAIFunction sut = new("plugin", "function", "description", null, null, strict);
+        OpenAIFunction sut = new("plugin", "function", "description", null, null);
 
         // Act
-        var result = sut.ToFunctionDefinition();
+        var result = sut.ToFunctionDefinition(strict);
 
         // Assert
         if (strict)
         {
             Assert.Equal("{\"type\":\"object\",\"required\":[],\"properties\":{},\"additionalProperties\":false}", result.FunctionParameters.ToString());
-            Assert.True(sut.Strict);
         }
         else
         {
             Assert.Equal("{\"type\":\"object\",\"required\":[],\"properties\":{}}", result.FunctionParameters.ToString());
-            Assert.False(sut.Strict);
         }
     }
 
@@ -105,9 +90,9 @@ public void SetsParametersToRequiredWhenStrict(bool strict)
         {
             new ("foo", "bar", false, typeof(string), null),
         };
-        OpenAIFunction sut = new("plugin", "function", "description", parameters, null, strict);
+        OpenAIFunction sut = new("plugin", "function", "description", parameters, null);
 
-        var result = sut.ToFunctionDefinition();
+        var result = sut.ToFunctionDefinition(strict);
 
         Assert.Equal(strict, result.FunctionSchemaIsStrict);
         if (strict)

diff --git a/dotnet/src/Connectors/Connectors.OpenAI.UnitTests/ToolCallBehaviorTests.cs b/dotnet/src/Connectors/Connectors.OpenAI.UnitTests/ToolCallBehaviorTests.cs
@@ -39,27 +39,23 @@ public void AutoInvokeKernelFunctionsReturnsCorrectKernelFunctionsInstance()
         Assert.Equal(DefaultMaximumAutoInvokeAttempts, behavior.MaximumAutoInvokeAttempts);
     }
 
-    [InlineData(true)]
-    [InlineData(false)]
-    [Theory]
-    public void EnableFunctionsReturnsEnabledFunctionsInstance(bool strict)
+    [Fact]
+    public void EnableFunctionsReturnsEnabledFunctionsInstance()
     {
         // Arrange & Act
-        List<OpenAIFunction> functions = [new("Plugin", "Function", "description", [], null, strict)];
+        List<OpenAIFunction> functions = [new("Plugin", "Function", "description", [], null)];
         var behavior = ToolCallBehavior.EnableFunctions(functions);
 
         // Assert
         Assert.IsType<EnabledFunctions>(behavior);
         Assert.Contains($"{nameof(EnabledFunctions)}(autoInvoke:{behavior.MaximumAutoInvokeAttempts != 0})", behavior.ToString());
     }
 
-    [InlineData(true)]
-    [InlineData(false)]
-    [Theory]
-    public void RequireFunctionReturnsRequiredFunctionInstance(bool strict)
+    [Fact]
+    public void RequireFunctionReturnsRequiredFunctionInstance()
     {
         // Arrange & Act
-        var behavior = ToolCallBehavior.RequireFunction(new("Plugin", "Function", "description", [], null, strict));
+        var behavior = ToolCallBehavior.RequireFunction(new("Plugin", "Function", "description", [], null));
 
         // Assert
         Assert.IsType<RequiredFunction>(behavior);

diff --git a/dotnet/src/SemanticKernel.UnitTests/Functions/KernelFunctionMetadataTests.cs b/dotnet/src/SemanticKernel.UnitTests/Functions/KernelFunctionMetadataTests.cs
@@ -219,7 +219,6 @@ public void CopyConstructorCopiesPropertiesValues()
                 { "method", "POST" },
                 { "path", "/api/v1" },
             }),
-            Strict = true,
             PluginName = "plugin",
             Name = "funcA",
         };
@@ -231,7 +230,6 @@ public void CopyConstructorCopiesPropertiesValues()
         Assert.Equal(original.Parameters, copy.Parameters);
         Assert.Equal(original.PluginName, copy.PluginName);
         Assert.Equal(original.ReturnParameter, copy.ReturnParameter);
-        Assert.Equal(original.Strict, copy.Strict);
     }
 
     private static void ValidFunctionName() { }