Add fix for empty response from Xero on push invoice #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return $this->getSingleton($connector_id)->Invoices($accountsInvoice); | ||
| $result = $this->getSingleton($connector_id)->Invoices($accountsInvoice); | ||
| // Note: One day it would be nice to switch to the new Xero PHP SDK method for pushing invoices. | ||
| // For some reason pushing certain invoices seems to result in a completely empty response |
There was a problem hiding this comment.
@mattwire on my last round of work on this I found the completely empty responses had headers that indicated the issue (throttling in the case I was looking at)
I did some stuff to look in the headers but I don't think it affected all paths
There was a problem hiding this comment.
Ah, interesting. We can leave this open until I get chance to look at that then :-)
There was a problem hiding this comment.
Ah - this is where I did it 48be1f9#diff-95bea40777ff719d8f405079e553aeef371b093a33d0970b08b134694265402eR311-R326
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.