[ruby/tmpdir] Fix for path-like objects

Fix ruby/tmpdir#37 ruby/tmpdir@a8ceafae7d
eightbitraptor · Dec 16, 2024 · bf0f323 · bf0f323
1 parent eef4e8a
commit bf0f323
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/tmpdir.rb b/lib/tmpdir.rb
@@ -149,8 +149,8 @@ def next
 
     # Generates and yields random names to create a temporary name
     def create(basename, tmpdir=nil, max_try: nil, **opts)
-      origdir = tmpdir
       if tmpdir
+        origdir = tmpdir = File.path(tmpdir)
         raise ArgumentError, "empty parent path" if tmpdir.empty?
       else
         tmpdir = tmpdir()

diff --git a/test/test_tmpdir.rb b/test/test_tmpdir.rb
@@ -108,6 +108,16 @@ def test_mktmpdir_not_empty_parent
     assert_raise(ArgumentError) do
       Dir.mktmpdir("foo", "")
     end
+
+    path = Struct.new(:to_path).new("")
+    assert_raise(ArgumentError) do
+      Dir.mktmpdir("foo", path)
+    end
+
+    Dir.mktmpdir do |d|
+      path = Struct.new(:to_path).new(d)
+      assert_operator(Dir.mktmpdir("prefix-", path), :start_with?, d + "/prefix-")
+    end
   end
 
   def assert_mktmpdir_traversal