Skip to content

Commit

Permalink
eicrecon: do not require acts +identification, but require +json (#654)
Browse files Browse the repository at this point in the history
### Briefly, what does this PR introduce?
As of Acts-35 there is no more `identification` variant. We don't need
it (but CMake-require it for EICrecon versions up to 1.15). After 1.15,
we should get rid of it in the CMake requirements and not require it in
eic-spack either.

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [x] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __
  • Loading branch information
wdconinc committed Jul 7, 2024
1 parent 7fef2b6 commit 2d18fd3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/eicrecon/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,8 @@ class Eicrecon(CMakePackage):
depends_on("edm4hep")
depends_on("podio")

depends_on("acts +dd4hep +identification +tgeo")
depends_on("acts +dd4hep +identification +tgeo", when="@:1.15")
depends_on("acts +dd4hep +json", when="@1.16:")
depends_on("acts@30:", when="@1.8:")
depends_on("acts@:30", when="@:1.9.0")

Expand Down

0 comments on commit 2d18fd3

Please sign in to comment.