Skip to content

Releases: eic/EICrecon

v1.17.0

18 Sep 00:05
ca9579e
Compare
Choose a tag to compare

What's Changed

🕸️ Tracking

  • feat: add track associations based on raw hit association, weighted by number of hits by @wdconinc in #1564
  • TracksToParticles: propagate MC associations from Tracks by @veprbl in #1589
  • Update to seed finder distance parameter by @bschmookler in #1586
  • IterativeVertexFinder: fill vertex-to-particle relation by @starsdong in #1576
  • fix: IterativeVertexFinder Acts v33 compatibility by @wdconinc in #1610

🪪 Particle identification

  • tracking: use Seeded tracks by default, rename previous default to TruthSeeded by @veprbl in #1605

🚿 Calorimetry

  • src/detectors: remove unused dimScaledLocalDistXY settings by @veprbl in #1567
  • CalorimeterIslandCluster: fix incorrect distance parameter priorities by @veprbl in #1568
  • treewide: use podio:output_collections instead of deprecated podio:output_include_collections by @veprbl in #1578
  • fix: list correct dimension in ImagingTopoCluster by @wdconinc in #1579
  • fix: introduce sorted index proxy to allow early break on neighbor search by @wdconinc in #1581
  • fix: deterministic cluster time by @wdconinc in #1584
  • fix: write local position in mm in CalorimeterHitsMerger by @wdconinc in #1598
  • fix: typo in comment by @wdconinc in #1599
  • allow MultiSegmentation in calorimeter hit recon by @sebouh137 in #1594
  • HcalEndcapPInsertImagingProtoClusters: use a larger hit spacing threshold by @sebouh137 in #1595
  • feat: produce *RawHitAssociations in CalorimeterHitDigi by @wdconinc in #1601
  • fix: avoid division by zero by using realistic ZDC Hcal digitization by @wdconinc in #1593
  • updated MIP value in insert; also adjusted parameters of the topo clustering by @sebouh137 in #1611
  • Add Track-Based Cluster Merging Algorithm by @ruse-traveler in #1406
  • Create Multiple Primary MC-Cluster Associations by @ruse-traveler in #1396
  • increased w0 parameter in cluster CoG for the ZDC by @sebouh137 in #1617

⚙️ Infrastructure

  • fix: add rule to ubsan.supp to avoid spurious UB warning by @wdconinc in #1582
  • fix(ci): pin upload-artifact/merge to v4.3.5 by @wdconinc in #1591
  • PIDLookup: set mass consistent with the assigned PID by @veprbl in #1560
  • linux-eic-shell.yml: continue-on-error for graphviz rendering by @veprbl in #1596
  • fix: CMake only needs CXX compiler by @wdconinc in #1597
  • reco.cc: add InclusiveKinematicseSigma backwards compatibility for now by @veprbl in #1577
  • fix(ci): use {ref,new} labels on capybara plots by @wdconinc in #1602
  • feat(ci): store prmon summary as artifact by @wdconinc in #1603
  • Correct xml file being called for different beam settings in CI by @simonge in #1616

🔩 Other Changes

  • fix: MPDG -> MPGD by @wdconinc in #1562
  • Remove MPGDDIRC hits from tracking.cc by @mposik1983 in #1569
  • InclusiveKinematicseSigma -> InclusiveKinematicsESigma by @veprbl in #1572
  • JEventProcessorPODIO.cc: remove duplicate B0ECal* entries by @veprbl in #1604
  • PIDLookup: avoid complaining about ambiguous associations by @veprbl in #1612
  • JEventProcessorPODIO: make podio:output_include_collection deprecation warning more compelling by @veprbl in #1606
  • eicrecon_cli: disable parameter tables for JANA2 2.3.x by @veprbl in #1614
  • ScatteredElectronsEMinusPz: refactor to use algorithms interface and ParticleSvc by @veprbl in #1615
  • GeometrySplit functor isn't threadsafe by @simonge in #1607
  • added PrimaryVertices factory (subCollection of CentralTrackVertices) by @starsdong in #1609

Full Changelog: v1.16.1...v1.17.0

v1.16.1

08 Aug 02:10
78b5481
Compare
Choose a tag to compare

What's Changed

🚿 Calorimetry

  • feat: print error when raw hit has amplitude > ADC capacity by @wdconinc in #1558
  • CalorimeterIslandCluster: avoid complaining about missing readouts by @veprbl in #1559
  • lowered the amount of distance neighbor hits in topoclustering in the ZDC by @sebouh137 in #1532

🔩 Other Changes

  • fix: avoid division by zero in UndoAfterBurner when no beam particles by @wdconinc in #1553
  • fix: avoid division by zero in neutron identification when no Hcal cluster by @wdconinc in #1548

Full Changelog: v1.16.0...v1.16.1

v1.16.0

07 Aug 16:20
134f1bf
Compare
Choose a tag to compare

What's Changed

🕸️ Tracking

  • feat: fix compilation for Acts versions from v33 up to v35 by @wdconinc in #1525
  • CalorimeterClusterRecoCoG: set intrinsic{Phi,Theta} by @veprbl in #1511
  • TracksToParticles: avoid initializing mass from truth by @veprbl in #1534
  • Added missing seed finder parameter by @bschmookler in #1544
  • fix: properly const_cast dynamic BField pointer by @wdconinc in #1555
  • Add one-to-one relation with raw tracker/calorimeter hit for reconstructed tracker/calorimeter hit by @rahmans1 in #1535

🪪 Particle identification

  • BTOF,DRICH,DIRC,PFRICH: unroll PID LUT factory initialization loops by @veprbl in #1536

🚿 Calorimetry

  • Fix: Correct ZDC LYSO Sampling Fraction by @bschmookler in #1529
  • ImagingTopoCluster: fix Init printouts by adding missing break statements by @sebouh137 in #1533
  • BHCAL: drop support for legacy sectors by @veprbl in #1540
  • CalorimeterIslandCluster: switch to use EvaluatorSvc by @veprbl in #1550
  • CalorimeterIslandCluster: peakNeighbourhoodMatrix to control how far peaks need to be to split by @veprbl in #1554
  • fix: rm repeated information logging line in CalorimeterIslandClustering by @wdconinc in #1556
  • fix: avoid integer wraparound in CalorimeterHitDigi by @wdconinc in #1557

⚙️ Infrastructure

  • fix: don't require Acts::{Identification,TGeo} component, but require Json by @wdconinc in #1520
  • linux-eic-shell.yml: don't trigger eic_container builds on schedule by @veprbl in #1527
  • fix: rm unneeded CMakeLists lines by @wdconinc in #1528
  • linux-eic-shell.yml: build against 24.05.2-stable container by @veprbl in #1471
  • fix(ci): split dot convert to svg into separate step by @wdconinc in #1546
  • fix(ci): suppress more UB false positives out of our scope by @wdconinc in #1547

🔩 Other Changes

  • InclusiveKinematicsML: avoid Ort::Env going out of scope by @veprbl in #1542
  • InclusiveKinematicsML: gracefully handle non-tensor types by @veprbl in #1543
  • fix: do not override log level to debug for JEventProcessorPODIO by @wdconinc in #1552
  • fix: no more JANA2 banner, since now JANA2 itself prints one for us by @wdconinc in #1549

Full Changelog: v1.15.0...v1.16.0

v1.15.0

01 Jul 22:30
07df19f
Compare
Choose a tag to compare

What's Changed

🕸️ Tracking

🚿 Calorimetry

⚙️ Infrastructure

🔩 Other Changes

  • Introduce MCBeamNeutron and MCBeamHadron Collections by @simonge in #1497
  • Make TaggerTracker and/or central tracks optional by @simonge in #1503
  • s/ROOTFrameWriter/ROOTWriter/ by @veprbl in #1411
  • fix: require AlgorithmsInit_service in IrtCherenkovParticleID for ParticleSvc by @wdconinc in #1522
  • treewide: add missing AlgorithmsInit_service for particleSvc by @veprbl in #1524

Full Changelog: v1.14.1...v1.15.0

v1.14.1

09 Jun 19:18
26ab0b2
Compare
Choose a tag to compare

What's Changed

🚿 Calorimetry

🔩 Other Changes

Full Changelog: v1.14.0...v1.14.1

v1.14.0

04 Jun 04:18
1413111
Compare
Choose a tag to compare

What's Changed

🕸️ Tracking

🪪 Particle identification

  • fix: convert to algorithms logger, no m_log in each algorithm class by @wdconinc in #1483

🚿 Calorimetry

⏩ Far Forward

⚙️ Infrastructure

  • fix: do not warn about BOOST_ROOT by @wdconinc in #1448
  • feat: pre-commit fix in place (interactive use only) by @wdconinc in #1449
  • Add FastJet plugin algorithms to jet reconstruction by @johnlajoie in #1378
  • build(deps): bump eic/trigger-gitlab-ci from 2 to 3 by @dependabot in #1451
  • fix(ci): slim down dot output by @wdconinc in #1452
  • fix: setup.sh -> bin/thisepic.sh by @wdconinc in #1457
  • linux-eic-shell.yml: use github.head_ref by @veprbl in #1458
  • linux-eic-shell.yml: use github.event.merge_group.base_ref by @veprbl in #1459
  • linux-eic-shell.yml: pass PIPELINE_NAME_CONTAINER by @veprbl in #1460
  • Neutron energy scale by @sebouh137 in #1454
  • feat: add matcher for ubsan warnings by @wdconinc in #1463
  • feat(ci): disable jana ticker; assemble JANA_OPTIONS in env variable by @wdconinc in #1465
  • build(deps): bump korthout/backport-action from 2 to 3 by @dependabot in #1472
  • Add low Q2 NN inference by @simonge in #1467
  • JEventProcessorPODIO: deprecate podio:output_include_collections parameter by @veprbl in #1466
  • Update linux-eic-shell.yml: PIPELINE_NAME_CONTAINER -> PIPELINE_NAME by @veprbl in #1485

🔩 Other Changes

  • omnifactory_test: fix "Immutable objects can only be added to subset collections" exception by @veprbl in #1439
  • fix: don't double-define logger LogLevel parameters by @wdconinc in #1436
  • feat: add plugin usage info to eicrecon -h by @wdconinc in #1479
  • Reconstructed inclusive kinematics algorithms now use centralized algorithms for scattered electron ID and hadronic final state calculation by @tylerkutz in #1453

New Contributors

Full Changelog: v1.13.2...qqqq

v1.13.2

12 May 20:50
83a8852
Compare
Choose a tag to compare

What's Changed

⏩ Far Forward

  • [v1.13] correct z positions of hits for RP by @veprbl in #1444

⚙️ Infrastructure

  • linux-eic-shell.yml: remove eicrecon-test-plugins[reco_test] by @veprbl in #1433

🔩 Other Changes

  • jana_plugin.cmake: fix typo by @veprbl in #1434
  • [v1.13] pid_lut: avoid overwriting PDG by @veprbl in #1438
  • [v1.13] PIDLookup: fix incorrect PDG convention - electron should not be -11 by @veprbl in #1445
  • [Backport v1.13] JetReconstructionConfig: reduce default ghost area to 0.01 by @epic-capybara in #1447

Full Changelog: v1.13.1...v1.13.2

v1.13.1

08 May 17:17
01ef680
Compare
Choose a tag to compare

What's Changed

⚙️ Infrastructure

  • cmake: force linkage of shared libraries by @veprbl in #1431

Full Changelog: v1.13.0...v1.13.1

v1.13.0

08 May 17:06
8f66e97
Compare
Choose a tag to compare

What's Changed

🕸️ Tracking

🪪 Particle identification

  • Prepare for OneToOne relation to SimHit in MCRecoTrackerHitAssociation by @veprbl in #1399
  • feat: convert IrtCherenkovParticleID factory to JOmniFactory by @wdconinc in #1418
  • feat: convert MergeCherenkovParticleID factory to JOmniFactory by @wdconinc in #1419
  • feat: rm JChainMultifactory by @wdconinc in #1421

🚿 Calorimetry

  • Remove outdated comment on mc-cluster associations by @ruse-traveler in #1388
  • LUMISPECCAL: LumiSpecCALHits -> EcalLumiSpecHits by @veprbl in #1381
  • treewide: fix "Immutable objects can only be added to subset collections" exception by @veprbl in #1379
  • CalorimeterHitReco: use TCling to define SF via expressions by @veprbl in #1349
  • fix: revert RandomSvc back to std::default_random_engine by @wdconinc in #1408
  • CalorimeterHitDigi: use EvaluatorSvc for corrMeanScale by @veprbl in #1410
  • fix: pass logger options from factory to algorithms-interfaced algorithms by @wdconinc in #1407
  • added a 'neutron reconstruction' algorithm which creates a neutron candidate that merges all clusters in a given bank by @sebouh137 in #1404
  • fix: rm include unused SpdlogMixin by @wdconinc in #1429

⚙️ Infrastructure

🔩 Other Changes

  • fix: CentralCKFActsTrajectories is the collection with ActsExamples::Trajectories by @wdconinc in #1385
  • hotfix: rm InclusiveKinematicsML from default output collections by @wdconinc in #1390
  • Add filter by association templated factory by @simonge in #1326
  • FarDetectorTrackerCluster.cc: ulong -> unsigned long by @veprbl in #1413
  • eicrecon: load PFRICH plugin by default by @veprbl in #1416
  • Created algorithm and factory for calculating hadronic final state variables by @tylerkutz in #1405

Full Changelog: v1.12.0...v1.13.0

v1.12.0

08 Apr 23:24
78efa24
Compare
Choose a tag to compare

What's Changed

🕸️ Tracking

  • Fix to seed theta and phi covariance indices by @bschmookler in #1345
  • feat: replace draw_surfaces with Acts-based obj and ply export by @wdconinc in #1357
  • 1300 putting real seeding covariance matrix error in a configuration file by @Jeet-bhai in #1335

🪪 Particle identification

  • fix: use proper EDM4hep getter in ParticlesWithPID.cc by @wdconinc in #1353
  • treewide: use PODIO ObjectID instead SimID/RecID indices by @veprbl in #1346

🚿 Calorimetry

  • feat: propagate AlgorithmsInit_service use for algorithms::GeoSvc by @wdconinc in #1311
  • CalorimeterHitDigi: require DD4hep readout to be present by @veprbl in #1351

⚙️ Infrastructure

🔩 Other Changes

  • remove JEventSourcePODIOLegacy by @veprbl in #1324
  • Combined and moved the Inclusive Kinematics factory code by @simonge in #1327
  • fix: convert MatchClusters to JOmniFactory and algorithms interface by @wdconinc in #1314
  • Add factory to create ReconstructedParticles in Breit frame by @johnlajoie in #1325
  • Fix Jet Algorithm Initialization Bug by @ruse-traveler in #1331
  • Update JetReconstruction to algorithm interface by @johnlajoie in #1344
  • fix: ensure eicrecon-this.sh prepends even when already in PATH by @wdconinc in #1205
  • Algorithms and factories for scattered electrons by @jdbrice in #1277
  • update RP matrices to account for shift of detector z-position by @ajentsch in #1328
  • Adapt ElectronReconstruction to use MatchClusters by @tlprotzman in #1355

New Contributors

Full Changelog: v1.11.0...v1.12.0