Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jana_plugin.cmake: explicitly depend plugins on podio_datamodel_glue #1772

Merged
merged 5 commits into from
Mar 25, 2025

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 25, 2025

Briefly, what does this PR introduce?

#1704 broke multiprocess builds (e.g. make -j10). The issue is that cmake header scanner ignores rule that generates datamodel_glue.h, which leads to race conditions:

src/services/io/podio/JEventSourcePODIO.cc:30:10: fatal error: services/io/podio/datamodel_glue.h: No such file or directory
   30 | #include "services/io/podio/datamodel_glue.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This PR introduces a target-level dependency. The case of external plugin is handled by the fact that the headers are installed along with EICrecon.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@veprbl veprbl force-pushed the pr/datamodel_glue_dep branch 3 times, most recently from a3f7cde to f111e07 Compare March 25, 2025 21:59
@veprbl veprbl force-pushed the pr/datamodel_glue_dep branch from e46d86f to 7c68219 Compare March 25, 2025 22:02
@veprbl veprbl requested a review from wdconinc March 25, 2025 22:12
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice simplification of common properties, and thanks for moving the generated include to a target.

@veprbl veprbl added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit 4d07fea Mar 25, 2025
85 of 86 checks passed
@veprbl veprbl deleted the pr/datamodel_glue_dep branch March 25, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants