Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup Additional Information Feature #68

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yashwanthgajji
Copy link
Contributor

This PR adds an additional function to add label to the popup properties content.

This fixes #64

Please let me know if this fix is okay for this issue.

Copy link
Owner

@ehsannarmani ehsannarmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yashwanthgajji , thank you so much for your interest and work on this project and issue.

But the exact issue and feature request was not which you implemented.

We already had access to label of line and show it in popup, because you can implement contentBuilder for each popup in line data class too, so you have access to line label in there, no needed to have line label in content builder lambda parameters.

For example:

data.map{
    Line(label = it.label, popupProperties = PopupProperties(contentBuilder = { value-> "${it.label}: $value"}))
}

But about the main goal and feature of this issue:
imagine you have this values as data: 20,15,10,17,18
and you have this values as labels for line values: 13 Dec, 14 Dec, 15 Dec, 16 Dec, 17 Dec
in the popupBuilder lambda, we should have access to current label of value
for example if you are dragging on line chart which is on 13 Dec range, we should have this in popupBuilder lambda

I hope I was able to convey the goal of issue, if you have any questions, ask.

@yashwanthgajji
Copy link
Contributor Author

Oh okay. Got your point. Will try that way

@jamu1989
Copy link

I need the data index in the builder where the value comes from. With that functionality I can build a relation between data source and presented value.

Example:
Bildschirmfoto 2025-01-25 um 11 45 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional Information in Popup
3 participants