Fix code duplication

ehmicky · May 5, 2024 · 1a80ede · 1a80ede
1 parent 48f21bc
commit 1a80ede
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/src/helpers/args.test.js b/src/helpers/args.test.js
@@ -0,0 +1,2 @@
+// Works on TEST_VERSION but not on OLD_TEST_VERSION
+export const printModernNodeArgs = ['node', '-p', '".".at(0)']
diff --git a/src/parallel.test.js b/src/parallel.test.js
@@ -1,13 +1,14 @@
 import test from 'ava'
 import { each } from 'test-each'
 
+import { printModernNodeArgs } from './helpers/args.test.js'
 import { runCli, runSerial, runParallel } from './helpers/run.test.js'
 import { TEST_VERSION, OLD_TEST_VERSION } from './helpers/versions.test.js'
 
 test('Forward exit code and output on late failure | runParallel', async (t) => {
   const { exitCode, stdout, stderr } = await runCli(
     `${TEST_VERSION},${OLD_TEST_VERSION}`,
-    ['node', '-p', '".".at(0)'],
+    printModernNodeArgs,
     ['--parallel', '--continue'],
   )
 
@@ -27,7 +28,7 @@ Node ${OLD_TEST_VERSION} failed with exit code 1`),
 test('No --continue | runParallel', async (t) => {
   const { exitCode, stdout, stderr } = await runCli(
     `${OLD_TEST_VERSION},${TEST_VERSION}`,
-    ['node', '-p', '".".at(0)'],
+    printModernNodeArgs,
     ['--parallel'],
   )
 
@@ -44,7 +45,7 @@ Node ${OLD_TEST_VERSION} failed with exit code 1`,
 test('--continue | runParallel', async (t) => {
   const { exitCode, stdout, stderr } = await runCli(
     `${OLD_TEST_VERSION},${TEST_VERSION}`,
-    ['node', '-p', '".".at(0)'],
+    printModernNodeArgs,
     ['--parallel', '--continue'],
   )
 

diff --git a/src/serial.test.js b/src/serial.test.js
@@ -1,12 +1,13 @@
 import test from 'ava'
 
+import { printModernNodeArgs } from './helpers/args.test.js'
 import { runCli } from './helpers/run.test.js'
 import { TEST_VERSION, OLD_TEST_VERSION } from './helpers/versions.test.js'
 
 test(`Forward exit code and output on late failure | runSerial`, async (t) => {
   const { exitCode, stdout, stderr } = await runCli(
     `${TEST_VERSION},${OLD_TEST_VERSION}`,
-    ['node', '-p', '".".at(0)'],
+    printModernNodeArgs,
   )
 
   t.is(exitCode, 1)
@@ -26,7 +27,7 @@ test(`Forward exit code and output on late failure | runSerial`, async (t) => {
 test(`--continue | runSerial`, async (t) => {
   const { exitCode, stdout, stderr } = await runCli(
     `${OLD_TEST_VERSION},${TEST_VERSION}`,
-    ['node', '-p', '".".at(0)'],
+    printModernNodeArgs,
     ['--continue'],
   )
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		// Works on TEST_VERSION but not on OLD_TEST_VERSION
		export const printModernNodeArgs = ['node', '-p', '".".at(0)']