DNS check should convert unicode domains first (#166)

* fix checkdnsrr not handling unicode domains properly * fix for php7.2
egulias · Apr 10, 2018 · 8790f59 · 1ed · Jun 19, 2018 · 8790f59
1 parent 114b663
commit 8790f59
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/EmailValidator/Validation/DNSCheckValidation.php b/EmailValidator/Validation/DNSCheckValidation.php
@@ -44,7 +44,7 @@ public function getWarnings()
 
     protected function checkDNS($host)
     {
-        $host = rtrim($host, '.') . '.';
+        $host = rtrim(idn_to_ascii($host, IDNA_DEFAULT, INTL_IDNA_VARIANT_UTS46), '.') . '.';
 
         $Aresult = true;
         $MXresult = checkdnsrr($host, 'MX');

diff --git a/Tests/EmailValidator/Validation/DNSCheckValidationTest.php b/Tests/EmailValidator/Validation/DNSCheckValidationTest.php
@@ -24,6 +24,9 @@ public function validEmailsProvider()
             ['"Abc@def"@example.com'],
             ['"Fred\ Bloggs"@example.com'],
             ['"Joe.\\Blow"@example.com'],
+
+            // unicide
+            ['ñandu.cl'],
         ];
     }