Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): update hashbrown dependency to 0.15.2 #342

Merged
merged 4 commits into from
Dec 30, 2024

Conversation

quanterion
Copy link
Contributor

@quanterion quanterion commented Dec 26, 2024

In Microsoft we recently got a security notification due to usage of hashbrown below 0.15.1
The borsh serialization of the HashMap did not follow the borsh specification. It potentially produced non-canonical encodings dependent on insertion order. It also did not perform canonicty checks on decoding.

This can result in consensus splits and cause equivalent objects to be considered distinct.

This was patched in 0.15.1.

@quanterion quanterion changed the title update deps fix(security): update hashbrown dependency to 0.15.2 Dec 26, 2024
@mwillsey
Copy link
Member

Looks good! Thanks for the PR!

@mwillsey mwillsey merged commit 30c9ec1 into egraphs-good:main Dec 30, 2024
2 checks passed
@quanterion
Copy link
Contributor Author

@mwillsey Thanks for merging this! Do you have any ideas when you are going to make a next release?

@mwillsey
Copy link
Member

I guess it has been a while. I will make one today!

@mwillsey
Copy link
Member

Here you go! https://crates.io/crates/egg

@quanterion
Copy link
Contributor Author

@mwillsey Thx a lot for present! Happy new year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants