Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proof OOM by actually counting all neighbors #340

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

pavpanchekha
Copy link
Contributor

This PR fixes the root cause behind herbie-fp/herbie#1084. Basically, Herbie will sometimes build a truly enormous egraph. The proofs code is supposed to early-exit in cases like this but it doesn't due to a bug. I don't really understand the bug, @oflatt helped on fixing it, but it takes memory usage on this benchmark from about ~24GB to about 0.

Copy link
Member

@oflatt oflatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
For more context:
There can be many different extra congruence edges between terms in the egraph (n^2 many)
This code was supposed to early exit after it hit too many, but it was miscounting the number of edges

@mwillsey mwillsey merged commit 6f2ac1e into egraphs-good:main Dec 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants