Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hashmap_with_capacity #313

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Add hashmap_with_capacity #313

merged 2 commits into from
Apr 24, 2024

Conversation

cospectrum
Copy link
Contributor

I'm using a separate function, because HashMap::with_capacity(cap) doesn't work for hashbrown and fxhash.

@mwillsey
Copy link
Member

Why not just say HashMap::with_capacity_and_hasher(cap, util::BuildHasher::default())?

@cospectrum
Copy link
Contributor Author

cospectrum commented Apr 24, 2024 •
edited
Loading

Why not just say HashMap::with_capacity_and_hasher(cap, util::BuildHasher::default())?

Too long, takes 2 lines, it's a matter of taste. I can change if you want

@mwillsey
Copy link
Member

Fair enough. Please change to hashmap_with_capacity for consistency and then we can merge.

@cospectrum
Copy link
Contributor Author

Fair enough. Please change to hashmap_with_capacity for consistency and then we can merge.

Done

@cospectrum cospectrum changed the title Add hash_map_with_capacity Add hashmap_with_capacity Apr 24, 2024
@mwillsey mwillsey merged commit c11d03d into egraphs-good:main Apr 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cospectrum @mwillsey