-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to create httpClient from app #5334
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #5334 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 36 36
Lines 3631 3648 +17
Branches 520 521 +1
=======================================
+ Hits 3626 3643 +17
Misses 5 5 ☔ View full report in Codecov by Sentry. |
@coderabbitai 提交一个 issue 跟进此 pr 后续会被合并到 master |
@fengmk2 已经提交了一个 issue 来跟进此 PR,后续会被合并到 master。您可以在以下链接查看和跟踪该 issue:https://github.com/eggjs/egg/issues/5335。 Analysis chainScripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
gh issue create --title "Follow-up on PR #5334: Allow to create httpClient from app" --body "This issue is to follow up on the changes proposed in PR #5334 (https://github.com/eggjs/egg/pull/5334). The PR aims to allow the creation of httpClient from the app.
Comment: https://github.com/eggjs/egg/pull/5334#issuecomment-1234567890
Assignee: @fengmk2" --assignee fengmk2
Length of output: 416 Actions performedComments resolved. |
No description provided.