test: fix unit test IP parsing error in Nodejs 18.X #5247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"handers" should be "handlers" in some comments. Refs: eggjs#5243.
Since Nodejs v18.16.x has upgraded the version of Ada, now if we use something like "numeric IP address", it cannot be parsed successfully. We should use Latin-like chars instead.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5247 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 36 36
Lines 3601 3601
Branches 516 516
=======================================
Hits 3596 3596
Misses 5 5 ☔ View full report in Codecov by Sentry. |
|
This is a fix for non-number IP address check, not sure if it's a bug of Nodejs or something else? Ref: nodejs/node#49024 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Nodejs v18.16.x has upgraded the version of Ada, now if we use
something like "numeric IP address", it cannot be parsed successfully.
We should use Latin-like chars instead.
npm testpasses