chore(typings): add class EggLoader #2321

waitingsong · 2018-04-05T09:35:03Z

Checklist

npm test passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

Description of change

codecov · 2018-04-05T09:46:57Z

Codecov Report

Merging #2321 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2321   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          29       29           
  Lines         825      825           
=======================================
  Hits          823      823           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80528cc...184edcd. Read the comment docs.

need commits of eggjs/egg#2321

waitingsong · 2018-04-05T11:26:50Z

用于 TS 的框架扩展 framework-ts-example

waitingsong · 2018-04-05T13:15:48Z

commit: 9334658
for: https://github.com/eggjs/examples hackernews-async-ts

atian25 · 2018-04-08T10:44:36Z

index.d.ts

@@ -968,4 +970,60 @@ declare module 'egg' {
      ? PowerPartial<T[U]>
      : T[U]
  };
+
+  export interface EggLoaderOptions {


prefer add these to egg-core

嗯当时考虑过在 egg-core 里面添加的。不过 egg 里面还需要 import 和 export 感觉有点麻烦

atian25 · 2018-04-09T02:50:28Z

index.d.ts

+
+    constructor(options: EggLoaderOptions);
+
+    private getServerEnv(): string; // not exists EggAppInfo['env']


private 的为啥要写出来？

没用的就干掉吧，别注释

下面的 worker 为啥不在 EggLoader 里面写？补全下其他函数

下面的 worker 为啥不在 EggLoader 里面写

没懂

need commits of eggjs/egg#2321

atian25 · 2018-04-12T02:22:51Z

看今天能否处理下，我下午发一个 egg patch。

whxaxes · 2018-04-12T02:33:56Z

index.d.ts

+    constructor(options: EggLoaderOptions);
+
+    getHomedir(): EggAppInfo['HOME']
+


EggLoader 里其实有很多暴露出来的方法可能是需要在上层框架中用到的，也需要补一下吧，比如 getLoadUnits ，loadToApp，loadToContext 这些？

方法比较多，如果在 EggCore 里面添加 index.d.ts 可能更清晰些。不过我对 typings 合并（到egg）机制不大清楚

不用，你直接加 d.ts 到 egg-core 中，然后在 egg 中 import 进来就行了，typings 合并到 egg 那个只是适用于上层框架、插件的

@whxaxes 你的意思是在 egg-core 项目中添加 egg-core/index.d.ts 文件么？

declare module 'egg' { <--- 'egg' OR 'egg-core' ? export interface EggAppInfo { pkg: any; // package.json name: string; // the application name from package.json baseDir: string; // current directory of application env: EggEnvType; // equals to serverEnv HOME: string; // home directory of the OS root: string; // baseDir when local and unittest, HOME when other environment } export interface EggLoaderOptions { baseDir: string; typescript?: boolean; app: Application; logger: Logger; plugins?: any; } export class EggLoader { options: EggLoaderOptions; constructor(options: EggLoaderOptions); getHomedir(): EggAppInfo['HOME'] getAppInfo(): EggAppInfo; } }

不过 EggAppInfo 这个类型是在 egg/index.d.ts 中定义的啊

可以有两种方式

egg-core 里面 import { EggLoaderOptions } from 'egg'，这样会循环依赖，但问题不大，运行是没有问题的

EggLoaderOptions 直接放 egg-core 里面，在 egg 里面 export { EggLoaderOptions } from 'egg-core'

need commits of eggjs/egg#2321

dead-horse · 2018-05-04T01:55:04Z

这个可以合并了？

atian25 · 2018-05-04T02:28:50Z

要 @shepherdwind @whxaxes 看看

popomore · 2018-05-04T02:45:07Z

@atian25 这个可以合了吗

whxaxes · 2018-05-10T01:53:10Z

EggLoader 先加进来应该也 OK

dead-horse · 2018-05-11T06:19:57Z

CI 没过

shepherdwind · 2018-05-10T01:52:17Z

index.d.ts

+    constructor(options: EggLoaderOptions);
+
+    getHomedir(): EggAppInfo['HOME']
+


可以有两种方式

egg-core 里面 import { EggLoaderOptions } from 'egg'，这样会循环依赖，但问题不大，运行是没有问题的

EggLoaderOptions 直接放 egg-core 里面，在 egg 里面 export { EggLoaderOptions } from 'egg-core'

waitingsong · 2018-06-13T09:49:48Z

我看看能否把 EggLoaderOptions 放到 egg-core

waitingsong · 2018-06-13T09:57:28Z

  export interface EggLoaderOptions {
    baseDir: string;
    typescript?: boolean;
    app: Application; // <--- 这个是 KoaApplication 的还是 Egg扩展后的的？
    logger: Logger;
    plugins?: any;
  }

waitingsong · 2018-06-13T10:00:20Z

  export interface EggLoaderOptions {
    baseDir: string;
    typescript?: boolean;
    app: Application; // <--- 这个是 KoaApplication 的还是 Egg扩展后的的？
    logger: Logger;
    plugins?: any;
  }

问问，楼上那个编辑过的有个弹框提示编辑历史，盖住了内容怎么能去掉呢

root, cache, defaultExtension

PowerPartial support by TypeScript v2.8.0+

waitingsong · 2018-06-16T05:53:22Z

appveyor v9 过了， v8挂了。啥情况呢

waitingsong · 2018-08-11T12:26:42Z

ci都过了

popomore · 2018-08-24T06:52:17Z

@whxaxes @waitingsong ci 过了就准备合并了

chore(typings): add class EggLoader (#2321)

waitingsong added a commit to waitingsong/eggjs-examples that referenced this pull request Apr 5, 2018

feat: add TypeScript framework-ts example

c25bd31

need commits of eggjs/egg#2321

waitingsong mentioned this pull request Apr 5, 2018

feat: add TypeScript framework-ts example eggjs/examples#68

Open

4 tasks

atian25 reviewed Apr 8, 2018

View reviewed changes

atian25 requested a review from whxaxes April 8, 2018 10:44

atian25 reviewed Apr 9, 2018

View reviewed changes

waitingsong added a commit to waitingsong/eggjs-examples that referenced this pull request Apr 10, 2018

feat: add TypeScript framework-ts example

e66eb75

need commits of eggjs/egg#2321

waitingsong force-pushed the ts branch from 00f5624 to 44aecb3 Compare April 10, 2018 11:57

whxaxes reviewed Apr 12, 2018

View reviewed changes

whxaxes mentioned this pull request Apr 12, 2018

当 Egg 遇到 TypeScript，收获茶叶蛋一枚 atian25/blog#27

Open

waitingsong added a commit to waitingsong/eggjs-examples that referenced this pull request Apr 29, 2018

feat: add TypeScript framework-ts example

9b8eefc

need commits of eggjs/egg#2321

atian25 requested a review from shepherdwind May 4, 2018 02:28

dead-horse mentioned this pull request May 5, 2018

Release 2.8.1 #2505

Merged

4 tasks

whxaxes approved these changes May 10, 2018

View reviewed changes

waitingsong force-pushed the ts branch from bcd898c to ff6de34 Compare June 13, 2018 08:58

shepherdwind approved these changes Jun 13, 2018

View reviewed changes

waitingsong added 3 commits June 14, 2018 10:35

chore(typings): add class EggLoader

a8b7c9f

chore(typings): add class AppWorkerLoader

830bc28

chore(typings): add class AgentWorkerLoader

afeb38c

waitingsong added 8 commits June 14, 2018 10:35

chore(typings): add class Subscription

68d7892

fix(typings): Property 'scope' does not exist on type 'EggAppInfo'.

a06d98d

chore(typings): change elements of EggAppConfig['view'] optional

08cb99e

root, cache, defaultExtension

chore(typings): revert to 6c32d10

0eb73c4

PowerPartial support by TypeScript v2.8.0+

chore(typings): comment private method of EggLoader out

1d40935

chore(typings): remove private method

71424c8

chore(typings): export types

8bc69a1

chore: prune

73cd071

waitingsong force-pushed the ts branch from aa83c3d to 73cd071 Compare June 14, 2018 02:36

Merge branch 'master' into ts

5a6f37f

popomore added 3 commits August 20, 2018 19:12

Merge branch 'master' into ts

c59b991

Merge branch 'master' into ts

fad30ec

Merge branch 'master' into ts

184edcd

popomore merged commit db1286d into eggjs:master Aug 24, 2018

popomore pushed a commit that referenced this pull request Aug 24, 2018

docs: auto generate by ci

8070daa

chore(typings): add class EggLoader (#2321)

waitingsong deleted the ts branch August 24, 2018 08:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(typings): add class EggLoader #2321

chore(typings): add class EggLoader #2321

waitingsong commented Apr 5, 2018 •

edited

Loading

codecov bot commented Apr 5, 2018 •

edited

Loading

waitingsong commented Apr 5, 2018 •

edited

Loading

waitingsong commented Apr 5, 2018

atian25 Apr 8, 2018

waitingsong Apr 8, 2018

atian25 Apr 9, 2018

atian25 Apr 9, 2018

atian25 Apr 9, 2018

waitingsong Apr 10, 2018 •

edited

Loading

atian25 commented Apr 12, 2018

whxaxes Apr 12, 2018

waitingsong Apr 12, 2018 •

edited

Loading

whxaxes Apr 12, 2018

waitingsong Apr 13, 2018 •

edited

Loading

shepherdwind May 10, 2018

dead-horse commented May 4, 2018

atian25 commented May 4, 2018

popomore commented May 4, 2018

whxaxes commented May 10, 2018

dead-horse commented May 11, 2018

shepherdwind May 10, 2018

waitingsong commented Jun 13, 2018

waitingsong commented Jun 13, 2018 •

edited

Loading

waitingsong commented Jun 13, 2018

waitingsong commented Jun 16, 2018

waitingsong commented Aug 11, 2018

popomore commented Aug 24, 2018 •

edited

Loading


		constructor(options: EggLoaderOptions);

		private getServerEnv(): string; // not exists EggAppInfo['env']

		constructor(options: EggLoaderOptions);

		getHomedir(): EggAppInfo['HOME']

chore(typings): add class EggLoader #2321

chore(typings): add class EggLoader #2321

Conversation

waitingsong commented Apr 5, 2018 • edited Loading

Checklist

Affected core subsystem(s)

Description of change

codecov bot commented Apr 5, 2018 • edited Loading

Codecov Report

waitingsong commented Apr 5, 2018 • edited Loading

waitingsong commented Apr 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

waitingsong Apr 10, 2018 • edited Loading

Choose a reason for hiding this comment

atian25 commented Apr 12, 2018

Choose a reason for hiding this comment

waitingsong Apr 12, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

waitingsong Apr 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dead-horse commented May 4, 2018

atian25 commented May 4, 2018

popomore commented May 4, 2018

whxaxes commented May 10, 2018

dead-horse commented May 11, 2018

Choose a reason for hiding this comment

waitingsong commented Jun 13, 2018

waitingsong commented Jun 13, 2018 • edited Loading

waitingsong commented Jun 13, 2018

waitingsong commented Jun 16, 2018

waitingsong commented Aug 11, 2018

popomore commented Aug 24, 2018 • edited Loading

waitingsong commented Apr 5, 2018 •

edited

Loading

codecov bot commented Apr 5, 2018 •

edited

Loading

waitingsong commented Apr 5, 2018 •

edited

Loading

waitingsong Apr 10, 2018 •

edited

Loading

waitingsong Apr 12, 2018 •

edited

Loading

waitingsong Apr 13, 2018 •

edited

Loading

waitingsong commented Jun 13, 2018 •

edited

Loading

popomore commented Aug 24, 2018 •

edited

Loading