Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configure.ac #1622

Merged
merged 2 commits into from
Jul 7, 2024
Merged

Conversation

michaelortmann
Copy link
Member

@michaelortmann michaelortmann commented Jun 16, 2024

Found by: michaelortmann
Patch by: michaelortmann
Fixes:

One-line summary:
Update configure.ac

Additional description (if needed):
isascii() is POSIX 2001

Test cases demonstrating functionality (if applicable):
There is no actual known bug, but good configure diagnostics are helpful in catching any, and this PR enhances those.

@thommey
Copy link
Member

thommey commented Jul 6, 2024

What good does AC_HEADER_RESOLV do if we don't use it? At least this PR doesn't add using it

@michaelortmann
Copy link
Member Author

michaelortmann commented Jul 6, 2024

What good does AC_HEADER_RESOLV do if we don't use it? At least this PR doesn't add using it

We want good information from configure run, to be able to debug reports from users. So checking for the more "exotic" futures.

@michaelortmann
Copy link
Member Author

Alright, AC_HEADER_RESOLV doesnt really add anything.

@vanosg vanosg merged commit 25683ab into eggheads:develop Jul 7, 2024
22 of 23 checks passed
@michaelortmann michaelortmann deleted the update.configure.ac branch July 7, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants