Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file descriptor leak for tmpfile() in share.mod #1602

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

michaelortmann
Copy link
Member

@michaelortmann michaelortmann commented Jun 4, 2024

Found by: michaelortmann
Patch by: michaelortmann
Fixes:

One-line summary:
Fix file descriptor leak for tmpfile() in share.mod

Additional description (if needed):
If i remember correctly this issue has been reported by gcc -fanalyzer for quite some time, predating #1510, but was never tracked down to be a true positive, likely because of the code-flow / if else nesting.
(#1016 should be able to make file descriptor leaks visible, but we opted to not merge it)

Test cases demonstrating functionality (if applicable):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant