Remove compat vsnprintf() (eggdrop requires posix 2001) #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: vanosg
Patch by: michaelortmann
Fixes: #226
One-line summary:
Eggdrop depends on POSIX.1-2001, which defines
vsnprintf().Additional description (if needed):
This PR keeps
egg_vsnprintf()for backward compatibility to (older) modules but redefines it to usevsnprintf()directly with a one-liner define ineggdrop.h.All egg_vsnprintf() were replaced by vsnprintf():
find ./ -type f -exec sed -i 's/egg_vsnprintf(/vsnprintf(/g' {} \;Note: don't do this in git directory. cd src/ first!
With this PR you must run misc/runautotools.
Test cases demonstrating functionality (if applicable):
No functional change. I tested 2 share bots, which successfully started and shared userfile.