inet_aton() -> inet_pton() #1461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thommey
reviewed
Oct 1, 2023
| @@ -526,7 +526,7 @@ Function global_table[] = { | |||
| (Function) sock_has_data, | |||
| (Function) bots_in_subtree, | |||
| (Function) users_in_subtree, | |||
| (Function) egg_inet_aton, | |||
| (Function) 0, /* was egg_inet_aton -- use inet_pton() instead */ | |||
There was a problem hiding this comment.
can't we just export inet_aton here then to avoid breaking modules?
There was a problem hiding this comment.
inet_aton is not posix. inet_aton(y,z) could be mapped to inet_pton(AF_INET,y,z), but thats not equivalent. inet_aton accepts numbers-and-dots notation, something inet_pton doesnt, so it could potentially break modules anyway. given the module api breakage, i propose we milestone this PR for eggdrop 1.10 pr newer.
There was a problem hiding this comment.
if we can risk theoretical breakage, we could of course export inet_aton if available, and export 0 otherwise. if that is what you had in mind.
Merge done to fix merge conflict
Merge done to fix merge conflict
Merge done to fix merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: michaelortmann
Patch by: michaelortmann
Fixes:
One-line summary:
inet_aton() -> inet_pton()
Additional description (if needed):
inet_pton() is POSIX 2001 and additionally supports IPV6
other egg_inet_aton() / inet_aton() calls within eggdrop were already replaced with inet_pton
This PR fixes the rest / module API
Please run misc/runautotools when testing / merging this PR
Test cases demonstrating functionality (if applicable):