Fix putlog timestamp: localtime() -> localtime_r() #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelortmann
changed the title
michaelortmann
changed the title
michaelortmann
pushed a commit
to michaelortmann/eggdrop
that referenced
this pull request
Nov 21, 2023
…e of eggheads#1441 and eggheads#1087 for better logging during debug session
michaelortmann
pushed a commit
to michaelortmann/eggdrop
that referenced
this pull request
Nov 21, 2023
…e of eggheads#1441 and eggheads#1087 for better logging during debug session
Closed
Merge done to trigger new CI run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: Arno
Patch by: michaelortmann
Fixes:
One-line summary:
Fix putlog timestamp: localtime() -> localtime_r()
Additional description (if needed):
No, eggdrop didnt invent the time machine, it just suffered from thread-unsafe localtime():
[21:55:36] Writing user file...
[21:55:35] Writing channel file...
This bug was introduced in 2019 by my very self:
5b395f2
Also this patch replaces ctime() with ctime_r()
Test cases demonstrating functionality (if applicable):