Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: michaelortmann
Patch by: michaelortmann
Fixes:
One-line summary:
Additional description (if needed):
Fix "echo off" for command
.su
Fix propagating telnet status for command
.relay
The propagation is necessary, so that the destination bot can send telnet control codes like "echo off"
eggdrop has got a telnet detector
eggdrop/src/dcc.c
Lines 80 to 91 in ffb8c18
so we will send it exactly what it is looking for
Fix "echo on" for command
.relay
Test cases demonstrating functionality (if applicable):
1. Fix "echo off" for command
.su
Before:
After:
2. fix propagating telnet status for command
.relay
Start 2 Bots, BotA and BotB
Telnet to BotA
Before:
After:
3. Fix "echo on" for command
.relay
.relay BotB
Before:
After:
Additionally i successfully checked that the "echo on" is indeed working by temporarily commenting out the tputs() in source, then
.relay
ing to BotB and entering a wrong password. The password request did send "echo off". So, with "echo on" commented out, echo was off after relay came back.