Remove dependence of compress module on share module #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelortmann
force-pushed
the
fix401
branch
from
ee445d2
to
1050954
Compare
michaelortmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: maimizuno
Patch by: michaelortmann
Fixes: #401
One-line summary:
Remove dependence of compress module on share module
Additional description (if needed):
Instead of module_depend() use module_find()
New function compress_start_share() that links the compress mod funcs to share mod and that is called during compress mod start and used as callback during share mod start (to update func pointers)
See also: #547 (comment)
Test cases demonstrating functionality (if applicable):
I tested every load/unload combination of compress mod and share mod in partyline